Giter VIP home page Giter VIP logo

Comments (2)

jbernard avatar jbernard commented on June 20, 2024

Thanks for the thoughts. Just curious, is this coding style documented somewhere, or just your preference? You're saying remove the defined exceptions in dotfiles/exceptions.py and just use OSError, what about errno in that case? What I liked about the exceptions is that the code is very readable at the point of raise, I'm not passing in error strings, or formatting anything, just the dotfile name and the exception class does the rest - that seemed elegant to me. Can you post a snippet of what you had in mind? I'd love to remove them entirely as long as I can keep things readable in the main functions.

Cheers

from dotfiles.

prologic avatar prologic commented on June 20, 2024

FWIW I think it's fine to raise custom exceptions like this. It's not always a good idea in the case of librariy code but as this is a tool/application I think it's fine.

from dotfiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.