Race Condition on pgt Callback about django-mama-cas HOT 3 CLOSED

Thanks for catching that validation response mismatch! I've pushed up c29604d to resolve that issue.

Regarding the race condition, I'm not immediately clear on what the problem might be. I looked through the django-cas source you pointed out and didn't notice any apparent issues. The request that MamaCAS makes is a synchronous request, so validate_callback should already be waiting until the request succeeds or fails. I don't believe the core requests library even provides asynchronous requests any longer.

I noticed in your example code above that when you added in the sleep delay, the lookup field changed from pgtIou to tgt (I'm assuming to compensate for the PGT/PGTIOU bug). Did you test with just that one change, without the sleep delay as well?

Thanks!

from django-mama-cas.

Thanks for getting back to me on this, I have gotten rid of the sleep hack and the pgt lookup, and with the updated mama_cas code it all works fine 😄 .. I will mark this issue as resolved. your right about the async stuff, there must be something else going on, but its no longer a problem for me :)

I'm now using the master branch of my django-cas fork and everything seems to work.. now I've just got to get my head round granting and revoking per service..

Thanks again

from django-mama-cas.

Great! I'm glad that's working for you now. If it's helpful, I just released 0.8.1 that contains this fix, if you'd rather use a more official release version.

Thanks!

from django-mama-cas.