Giter VIP home page Giter VIP logo

Comments (7)

tarunpaul avatar tarunpaul commented on June 22, 2024

I have created a pull request
#75

Please let me know if this looks ok.

from django-mama-cas.

manelclos avatar manelclos commented on June 22, 2024

@tarunpaul thanks! I've taken a quick look and the PR is missing a test. I'd say that the for loop you created overwrites the attribute.text with the last value of the list. A test would prove me wrong ;)

Could you please add the test?

from django-mama-cas.

tarunpaul avatar tarunpaul commented on June 22, 2024

@manelclos I have added a test case. Please take a look.
And thank you for keeping up the code standards. Really appreciate it. :)

from django-mama-cas.

tarunpaul avatar tarunpaul commented on June 22, 2024

Hi @manelclos, Please let me know if this looks ok or if I have missed anything.
Few test environments seem to fail on travis-ci. Two of which are unable to connect to internet to download the specific python version.
But locally it seems to pass all test cases.

$ python3 runtest.py
Creating test database for alias 'default'...
Ran 157 tests in 1.767s
OK
Destroying test database for alias 'default'...

from django-mama-cas.

manelclos avatar manelclos commented on June 22, 2024

@tarunpaul just checked the code locally, all good! Let's see if @jbittel has some time to approve it.

from django-mama-cas.

tarunpaul avatar tarunpaul commented on June 22, 2024

Great!
Thank you @manelclos :)

from django-mama-cas.

jbittel avatar jbittel commented on June 22, 2024

Merged. Much appreciated!

from django-mama-cas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.