Comments (7)
I know we hate util classes, so what would be the best way of replicating the various IOUtils.toString
and FileUtils.toString
methods?
I'm thinking of introducing a new package-private class TextResource
, which would have four public constructors (reflecting what we use in jcabi-xml):
*TextResource(InputStream stream)
*TextResource(File file)
*TextResource(URL url)
*TextResource(URI uri)
So that, the following uses of commons-io
would be:
*IOUtils.toString(stream)
-> new TextResource(stream).toString()
*IOUtils.toString(url)
-> new TextResource(url).toString()
*IOUtils.toString(uri)
-> new TextResource(uri).toString()
*FileUtils.toString(file)
-> new TextResource(file).toString()
What do you think?
from jcabi-xml.
The idea is perfect, and the name TextResource
is correct, let's do it.
from jcabi-xml.
I created a pull request for it at #18, please review.
from jcabi-xml.
@carlosmiranda the task is for you now, follow these guidelines. Don't hesitate to ask any technical questions right here
from jcabi-xml.
@carlosmiranda The budget here is 30 mins, which is exactly how much time will be paid for, when the task is completed
from jcabi-xml.
@carlosmiranda I added 30 mins to your account, many thanks for working with the project!
from jcabi-xml.
Finished, thanks, closing..
from jcabi-xml.
Related Issues (20)
- not enough ctors in XSLDocument
- new parent 1.33.0 HOT 4
- refresh HOT 4
- Reusing `TransformerFactory.newInstance()` HOT 2
- compatibility with Saxon 11 HOT 4
- more logs about factories HOT 4
- load XSL only once per XSLDocument HOT 4
- cache of factories in XSLDocument may grow too big HOT 1
- Dependency Dashboard
- improve logging messages HOT 7
- `XSLDocument` is not thread-safe HOT 14
- XSLDocument ctor must accept SystemId in most cases HOT 4
- trace() instead of debug() HOT 3
- XMLDocument.with(Sources) forgets the SID HOT 6
- Challenges with Separating Error Messages and Exceptions in Saxon Library HOT 1
- Schema.check() must throw an exception with all inner exceptions inside
- XMLDocument.xpath returns only one element
- XMLDocumentTest.java:59-64: Implement XPath 2.0... HOT 8
- Add more constructors for SaxonDocument HOT 2
- Altered formatting of original XML
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jcabi-xml.