Giter VIP home page Giter VIP logo

Comments (3)

jcmellado avatar jcmellado commented on August 22, 2024

Could you provided the file that you are using for testing?

From the library documentation: "Degenerated polygons are discarded. That is, polygons with less than three vertices, polygons with collinear coordinates, polygons with vertices not contained in an only one plane, polygons crossing edges, and so on."

Only the first three vertices are taken for normal computation. That's the expected behaviour.

And about the triangulator.js fix. I don't see it really necessary, because "u" takes the previous value of "v" on each iteration, and that value seems to be always fine.

from hangar.

Blackiris avatar Blackiris commented on August 22, 2024

Hi Juan,

Thank you for your response,
We had an issue with this model :
http://scenemodels.flightgear.org/app.php?c=Models&a=view&id=5186 whose
a great number of faces were invisible using Hangar, but visible in
FlightGear itself. Some other models also had this issue but not as much
as this one.
You can download it from "Download model" link.

About triangulator.js, it is possible to have "v = len -1", but in the
next loop, given that "u= v" and that "len" is drecreased by 1, "u" can
equal "len". At least, making sure that "u < len" fix the bug.

Of course, feel free to accept this bug fix or not.

Best regards,
Julien Nguyen

Le 31/01/2016 12:58, Juan Mellado a Γ©crit :

Could you provided the file that you are using for testing?

From the library documentation: "Degenerated polygons are discarded.
That is, polygons with less than three vertices, polygons with
collinear coordinates, polygons with vertices not contained in an only
one plane, polygons crossing edges, and so on."

Only the first three vertices are taken for normal computation. That's
the expected behaviour.

And about the triangulator.js fix. I don't see it really necessary,
because "u" takes the previous value of "v" on each iteration, and
that value seems to be always fine.

β€”
Reply to this email directly or view it on GitHub
#6 (comment).

from hangar.

jcmellado avatar jcmellado commented on August 22, 2024

Ok, I'll try to fix the code along this week.

Thanks

from hangar.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.