Giter VIP home page Giter VIP logo

Comments (6)

jedwards1211 avatar jedwards1211 commented on June 10, 2024 1

Makes sense, yeah I'll remove the requirement hopefully later today, ping me if I forget :P

from async-throttle.

jedwards1211 avatar jedwards1211 commented on June 10, 2024

Okay actually it seems that @babel/preset-env still applies the regenerator transform for "targets": {"browsers": "last 2 versions"} so I'm tempted to keep @babel/runtime so that people don't have to go to the trouble of requiring regenerator-runtime/register themselves.

Also, the reason you were seeing that error is not because Babel isn't used server-side, it's because the runtime transform was applied to the code but babel-register is in devDependencies, I forgot to put it in primary dependencies.
Various other packages of mine have babel-register in dependencies which is why I wasn't getting this error myself.

So I'll upgrade to the latest @babel/runtime and put it in dependencies.

from async-throttle.

jedwards1211 avatar jedwards1211 commented on June 10, 2024

I guess another option is to use a conditional exports package and tell people to load the polyfills if necessary themselves...I dunno, what do you think?

from async-throttle.

jedwards1211 avatar jedwards1211 commented on June 10, 2024

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from async-throttle.

bhj avatar bhj commented on June 10, 2024

@jedwards1211 Awesome! Figured my PR was opinionated (don't use yarn for example...) but could be a reference. Appreciate the comments and thanks for pushing this out!

from async-throttle.

jedwards1211 avatar jedwards1211 commented on June 10, 2024

You're welcome!

from async-throttle.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.