Comments (14)
Thanks for your openness @kspearrin! Cannot think you're willing to contribute to this repo!
from rubywarden.
This is because mobile apps don’t have the newest update yet and the fix here isn’t backwards compat. They will go out tomorrow.
from rubywarden.
FWIW, current android release crashes on sync as well, because Data
isn't populated. It's (hopefully) a short-lived problem, but worth mentioning (and pretty easily rectified by generating a Data
hash before sending the cipherDetails
out the door).
The migration went perfectly for me with the auto-updated Firefox extension, and I have a... er... non-trivial database, so a big 👍 here.
from rubywarden.
I don't see this API change mentioned, but I am seeing this with the latest extension:
Mar 20 19:50:16 colo bitwarden: 1.2.3.4 - - [20/Mar/2018:19:50:16 +0000] "GET /api/accounts/revision-date HTTP/1.1" 404 18 0.0008
edit: disregard. this is not new and not breaking anything
from rubywarden.
Please see #36 and help test these changes to work with the new upstream clients.
from rubywarden.
Tested Safari extension and it works. But iOS app doesn't load db anymore. It just keeps spinning.
from rubywarden.
Side note: did your safari extension auto update to 1.25.x? I've been trying to test the auto-updates there but it seems like none of my extensions ever update.
from rubywarden.
I had some code in there to supply a legacy Data
object in the old format (as well as Uri
from Uris[0].Uri
) but Cipher#update_from_params
didn't support updating records from old clients, so I took it out. Since the new mobile clients are releasing tomorrow, I'll just wait to test with those.
from rubywarden.
@kspearrin I reinstalled extension. Didn't use update function.
from rubywarden.
Some issues:
- Can't add URL to item. Tried existing and new item. I see PUT request, but url not saved.
- Desktop app doesn't work, same problem as iOS app.
from rubywarden.
Confirmed, adding URI to an item seems to create a blank URI field.
from rubywarden.
That should be fixed with c3e0eb1. It was saving but the client was not reading it back properly because of the case.
@kspearrin It'd be really nice if all of the apps and API could agree on a case format 😀 It's odd that the browser extension sends everything in lowercase ("login": { "uris": [ "uri":
) but then requires it back as "Login": { "Uris": [ "Uri":
.
from rubywarden.
Yea, our server is case insensitive, so I guess we get a little lax with that. :-/ ideally everything would be camel.
from rubywarden.
Thanks for testing everyone, this functionality is now in HEAD
from rubywarden.
Related Issues (20)
- iOS app crash after latest update HOT 18
- How to backup and restore? HOT 2
- CORS for new Safari Extension HOT 7
- Problem to update or sync after update HOT 2
- using web vault
- Upgrade error
- Implement 2FA recovery code
- Deleting folder doesn't clear matching "folderId" from items
- Provide procedure to implement HTTPS HOT 2
- Error when importing passwords from KeePass HOT 4
- DEBUG messages HOT 1
- 404 error when deleting entry HOT 5
- Saving attachments does not work HOT 1
- Error when importing from KeePass 2.x
- Delete user HOT 1
- Invalid master password when unlocking desktop client HOT 2
- rubywarden no longer being updated HOT 5
- Fork? HOT 1
- - NoMethodError - undefined method `passwordhistory' for #<Cipher:0x00000008093a8b38>: HOT 1
- Import from Enpass? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rubywarden.