Giter VIP home page Giter VIP logo

Comments (2)

jcsteh avatar jcsteh commented on July 28, 2024

Urgh. I think this is similar to #423.

To report how many items were removed, OSARA saves the number of items before the action runs, then runs the action, then gets the number of items now, then subtracts the latter from the former. My guess is that because you're rippling all tracks, when you delete a whole item on one track, unless the items on all tracks line up precisely, REAPER has to split items on other tracks. So, even though you removed an item, there are now actually the same number of items: minus 1 for the removal, but plus 1 for the split.

I'm not quite sure how to fix this. We could look at the number of selected items before the removal instead and just assume they were all removed, but that's risky. We have no guarantee that REAPER actually removed only (or all of) those items, so we'd effectively be guessing, and I don't like guessing.

from osara.

jcsteh avatar jcsteh commented on July 28, 2024

I guess the assumption would be fine if we're certain those commands always operate on all selected items. However, I've just confirmed that item locking will prevent items from being deleted, so we'd have to handle that somehow.

Another possibility might be to store a list of items and call ValidatePtr on them all after we remove them, counting the items that fail to validate. That leaves the question: are there any of these item removal commands (bound to cmdRemoveItems or calling cmdhRemoveItems) which operate on anything other than selected items?

from osara.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.