Comments (8)
That being said, it is nice to make these changes in the pcbmodelgen parser, maybe accepting both options if possible. I don't know how and where to change, but if I have an idea I will do it.
from pcbmodelgen.
Oh! That will be easy, the last change was doing exactly that.
std::string ll;
if (kicad_version == "4.x")
ll = "Edge.Cuts";
else
ll = "\"Edge.Cuts\"";
So, it is just a matter of adjusting the version properly.
from pcbmodelgen.
Alright, fixed. It is in my PR.
from pcbmodelgen.
https://github.com/jcyrax/pcbmodelgen/pulls
from pcbmodelgen.
Oh! That will be easy, the last change was doing exactly that.
std::string ll; if (kicad_version == "4.x") ll = "Edge.Cuts"; else ll = "\"Edge.Cuts\"";
So, it is just a matter of adjusting the version properly.
Hi, Can you please tell me where do I make these changes? Where do I find pcbmodelgen parser?
Thanks.
from pcbmodelgen.
Oh, sorry @iampadik, did not see this before.
You can change this on this file source/ems.cpp
, line 864.
The original file here was already fixed I think. Source
from pcbmodelgen.
Hi Leoheck.
Thank you for your response. Yes, now I crosschecked, the changes are already made. But I couldn't use my kicad 5.1 layouts for simulation. I ultimately installed version 4 in windows, make the whole layout and then use pcbmodelgen, then it works.
May be I should again give it a try and think if I missed anything. Thanks anyway again!!
from pcbmodelgen.
This is a quite old report and since we alredy have Kicad 7, I am closing this issue.
from pcbmodelgen.
Related Issues (16)
- Can't use example script HOT 5
- Accept pr with clang-format? HOT 2
- Error in parser GetZone parser HOT 2
- Running it on Ubuntu 20.04 HOT 2
- Issues with the commands in generate_model.sh HOT 5
- error: the type for the property "hole_fill" cannot be found HOT 3
- KiCAD to OpenEMS (PCB export) HOT 8
- GCC 11: numeric_limits preventing compilation
- Failing to detect port HOT 6
- Problem with bottom pads HOT 5
- Project clarifications HOT 1
- pcbmodelgen on Kicad 6.0.8 doesn't generate output HOT 1
- Bad copper infills (kicad 7.0.0) HOT 3
- [SOLVED] can pcbmodelgen recognize primitive non-rectangular boards (Egde.Cuts)? HOT 1
- KiCAD 8 fillets, pads and fills not rendered
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pcbmodelgen.