Running with Kicad-5.1.6 instead of 5.99 (nightly builds) about pcbmodelgen HOT 8 CLOSED

That being said, it is nice to make these changes in the pcbmodelgen parser, maybe accepting both options if possible. I don't know how and where to change, but if I have an idea I will do it.

from pcbmodelgen.

Oh! That will be easy, the last change was doing exactly that.

    std::string ll;
    if (kicad_version == "4.x")
        ll = "Edge.Cuts";
    else
        ll = "\"Edge.Cuts\"";

So, it is just a matter of adjusting the version properly.

from pcbmodelgen.

Alright, fixed. It is in my PR.

from pcbmodelgen.

https://github.com/jcyrax/pcbmodelgen/pulls

from pcbmodelgen.

Oh! That will be easy, the last change was doing exactly that.

    std::string ll;
    if (kicad_version == "4.x")
        ll = "Edge.Cuts";
    else
        ll = "\"Edge.Cuts\"";

So, it is just a matter of adjusting the version properly.

Hi, Can you please tell me where do I make these changes? Where do I find pcbmodelgen parser?
Thanks.

from pcbmodelgen.

Oh, sorry @iampadik, did not see this before.
You can change this on this file source/ems.cpp, line 864.

The original file here was already fixed I think. Source

from pcbmodelgen.

Hi Leoheck.

Thank you for your response. Yes, now I crosschecked, the changes are already made. But I couldn't use my kicad 5.1 layouts for simulation. I ultimately installed version 4 in windows, make the whole layout and then use pcbmodelgen, then it works.

May be I should again give it a try and think if I missed anything. Thanks anyway again!!

from pcbmodelgen.

This is a quite old report and since we alredy have Kicad 7, I am closing this issue.

from pcbmodelgen.