Current .start(Activity activity) functionality is limiting. about android-crop HOT 10 CLOSED

Have you tried using the variant of Crop.start() that takes a Context and Fragment? Or do you mean that you need getIntent() to be visible so that you can make changes to the Intent before starting it?

from android-crop.

I ran into similar limitations when launching from a support library fragment. Overloading Crop.start() does the trick, but it doesn't seem to be the most flexible solution (passing extras to the launched intent would require yet another overload), and it adds a useless dependency to the gradle build. IMHO it would be simpler to somehow expose getIntent() rather than trying to foresee all the possible use cases.

from android-crop.

Here is an implementation that does the trick for compatibility just for others who need a quick fix:

package com.soundcloud.android.crop;

import android.content.Context;
import android.net.Uri;
import android.support.v4.app.Fragment;

/**
 * Brings a way to use Crop with the compat library. Make sure that this class is 
 * placed in the com.soundcloud.android.crop package
 *
 * Created by Vincent Mimoun-Prat @ MarvinLabs, 04/08/2014.
 */
public class CropCompat extends Crop {

    public CropCompat(Uri source) {
        super(source);
    }

    @Override
    public CropCompat output(Uri output) {
        super.output(output);
        return this;
    }

    @Override
    public CropCompat withAspect(int x, int y) {
        super.withAspect(x, y);
        return this;
    }

    @Override
    public CropCompat asSquare() {
        super.asSquare();
        return this;
    }

    @Override
    public CropCompat withMaxSize(int width, int height) {
        super.withMaxSize(width, height);
        return this;
    }

    public void start(Context context, Fragment fragment) {
        fragment.startActivityForResult(getIntent(context), REQUEST_CROP);
    }
}

from android-crop.

I think the best resolution for this is a compat module that can be included as a separate dependency, but I don't feel strongly against increasing the visibility of getIntent() as well.

from android-crop.

Any ETA for the release of the enhancement?
Can you also included fixes in the whole picker functions as well?
Thanks!
(I tried implementing your workaround for the pickImage but couldn't get it working... some help would be very much appreciated!)

from android-crop.

Any updates on this? Seems to be crippling an otherwise very useful lib!

from android-crop.

Running into similar problem :(

from android-crop.

Hi,

Has there been any progress on this?

from android-crop.

@axelfran Yep. This is fixed since at least 1.0.0.

from android-crop.

Thanks, @jdamcd! :)

from android-crop.