Dist file without sourceMappingURL about jdataview HOT 5 OPEN

It totally can be included. Browser doesn't download source map unless you open devtools, so no 404 would happen.

from jdataview.

And well - the CDN version of library already points to correct source map so I'm not sure why you would ever get 404. http://jdataview.github.io/dist/jdataview.js

from jdataview.

When including jDataView through bower/requirejs, the sourcemap file is not part of the build (and neither should it be IMO).

from jdataview.

It's not part of the build - it should be just in the public folder where you put everything else. Source maps are important for debugging any problems, otherwise you might not find where the issue is and should you want to report it, I would be unable to find it as well. That's why all the libraries try to provide it or devs try to generate it as a part of build process. Moreover - your real users will never get 404 error even if you decide not to include it for some reason, so I don't see a problem.

from jdataview.

In development, it is fine to have sourcemaps in a public folder. That is why I would expect there to be a non-minified version of a library with sourcemap (if applicable), and a minified version without sourcemap. That way, in development, you can use the non-minified file with sourcemap to try to debug problems while using the minified version without sourcemap in a production environment.

Working through our setup to explain the details of why this is a problem for us, it seems that I stumbled upon the real source of frustration in our setup; gruntjs/grunt-contrib-requirejs#95 . Our problem was that while inspecting the production site, we generated 404s seemingly due to the missing jdataview.js.map file and PHPIDS banned us temporarily if causing enough 404s from the same IP (our office). The real cause of frustration was that (seemingly, at least) grunt-contrib-requirejs adds a semi-colon at the end of the sourcemap url (and jdataview is the only library we use with a dist-file with sourcemap), and due to the semicolon the comment was not stripped away by uglify2. This in turn led PHPIDS to give extra "attack score" on the sourcemap 404s due to the semicolon at the end (detected as an XSS attempt).

So, while I still think the minified version could be without sourcemap and the non-minified with sourcemap, it's totally up to you to decide.

Thanks for your effort on jDataView!

from jdataview.