Giter VIP home page Giter VIP logo

Comments (8)

jdholtz avatar jdholtz commented on September 14, 2024

This is a good idea. Would you prefer the arguments to be in config.json or passed through the command line? I could support both, but having many cli arguments might be confusing to some users.

from auto-southwest-check-in.

dylansison avatar dylansison commented on September 14, 2024

I’d say config.json or maybe a reference file you can link in the command line command?
in a perfect world you could have it be a docker container reference a file outside of the docker container so you can readily change which user’s accounts are being watched
i tend to like making things more complicated tho so idk really if it’s the easiest or best solution
if you’d do an updating accounts list file, probably useful to only make it update when the file changes but I definitely dunno how to do that

from auto-southwest-check-in.

jdholtz avatar jdholtz commented on September 14, 2024

You can link an outside file into Docker using volumes. I haven’t tested it, but you should be able to add --volume /path/to/config.json:/app/config.json to the docker run command so you don’t have to rebuild the container every time you change the configuration. Although, it only takes a few seconds to rebuild the Docker container with the new changes.

It would be unnecessarily complicated to have a file that is periodically read from the script as it is running (I’m not sure if this is what you are suggesting or not). It doesn’t take long to rebuild/restart the Docker container in case of changes to the config file, so this wouldn't add any benefit.

from auto-southwest-check-in.

ericlamus avatar ericlamus commented on September 14, 2024

+1 on this feature/suggestion. I've been using two VMs for this. Personally, I'd prefer command line argument as my girlfriend isn't always traveling with me. But I guess we can use config-solo.json, versus config-family.json.

from auto-southwest-check-in.

jdholtz avatar jdholtz commented on September 14, 2024

Would it be desired to have a separate configuration for each account/flight? I’ve started progress on this feature here. You can pass in additional accounts/flights into the config but every account would use the same notifications, interval, etc.

from auto-southwest-check-in.

dylansison avatar dylansison commented on September 14, 2024

I think, for simplicity, it'd work better to just have it scan all listed accounts for flights (daily?) since it's rare that you only want someone's flights to automatically be checked in sometimes (unless you're running this as a paid service).

If you mean configurables by account, I don't exactly see why you'd want people to be notified individually of their specific flight but it's possible I suppose?

About the file being read by the script from the Docker container, I suppose just to make sure no one forgets, if possible, add something that restarts the container when the file changes?

from auto-southwest-check-in.

jdholtz avatar jdholtz commented on September 14, 2024

I will keep the configuration level at the global level for now, and can potentially make changes if per account configuration is desired.

To actually restart the script/container when the config file changes, I would need to add a separate service to rebuild/restart the Docker containers as changes don’t actually get made within the container (and continuous file-watching is a fairly complicated thing on its own). If someone else wants to create that service, that would be great but I want that to be separate from this project (You can also use external tools to do this).

from auto-southwest-check-in.

jdholtz avatar jdholtz commented on September 14, 2024

Hey @dylansison and @ericlamus. I have fully implemented this feature at #33. It would be great if you could test this yourselves to verify it is working correctly. To get the new changes, just run git pull && git checkout multiple_accounts_and_flights. The Configuration guide gives detailed information on how to enter multiple accounts/flights into the script.

from auto-southwest-check-in.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.