Giter VIP home page Giter VIP logo

Comments (6)

victorbutler avatar victorbutler commented on September 14, 2024 1

Coincidentally, I happened to be looking at this exact thing just now. I haven't done it before, but dgtlmoon / changedetection.io seems to do this nicely via GitHub Container Registry when a new release is tagged.

https://github.com/dgtlmoon/changedetection.io/blob/master/.github/workflows/containers.yml for reference

from auto-southwest-check-in.

jdholtz avatar jdholtz commented on September 14, 2024 1

Thanks for the detailed response @drippyer. I will look into how other projects currently do it and how I could replicate that for this project.

from auto-southwest-check-in.

jdholtz avatar jdholtz commented on September 14, 2024

This is a good idea. However, the original image would not have the user's config.json. I could set up a volume in the image and link it to a location in the filesystem, but that is OS-dependent and might limit where the config file can reside. Thoughts on this? I'm not sure if Docker already has an inbuilt system for this (possibly by specifying the --volume flag in the docker run command).

from auto-southwest-check-in.

drippyer avatar drippyer commented on September 14, 2024

I could set up a volume in the image and link it to a location in the filesystem, but that is OS-dependent and might limit where the config file can reside. Thoughts on this? I'm not sure if Docker already has an inbuilt system for this (possibly by specifying the --volume flag in the docker run command).

Docker standalone run has the --mount and --volume flags for mounting to a local directory, and docker-compose uses

  container:
    image: repo/image
    volumes:
      - local_relative_dir:/container_dir

It should be feasible for users to create a local directory (something like auto-southwest-data) to house the config.json, and automatically create an config.example.json in the user-defined directory if it doesn't exist, checking beforehand to make sure that a valid config.json is not already present. Then the container should run normally if there is a valid config.json, or exit with information to the user explaining how to modify it if not.

I can try to look into some of the other containers I have in use to see if I can understand their volume/config/data management when user data is required, though Apprise is one that immediately comes to mind.

Ultimately, if someone is using docker-compose to get it set up, then it should remove most if not all of the OS-dependency as the config directory would just need to reside within the same parent dir as the docker-compose to work out of the box, and allows for easier customization for users wanting to store that in a different location.

from auto-southwest-check-in.

jdholtz avatar jdholtz commented on September 14, 2024

Hey @drippyer. In #55, I added a workflow to automatically build the image when a release is published. Additionally, I updated the documentation to point users to download the image from my public repository. Could you pull the image to make sure everything is working how you want it? The only image currently available is jdholtz/auto-southwest-check-in:develop. The repository can be found here.

from auto-southwest-check-in.

jdholtz avatar jdholtz commented on September 14, 2024

Currently, only develop image tags are created. The latest and vX.X images will be created after the next release.

from auto-southwest-check-in.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.