Giter VIP home page Giter VIP logo

Comments (5)

jedisct1 avatar jedisct1 commented on August 26, 2024

No problem :) You can use NULL as the master key.

from libhydrogen.

spinda avatar spinda commented on August 26, 2024

Great, thanks!

from libhydrogen.

spinda avatar spinda commented on August 26, 2024

Passing in NULL for the master_key parameter actually leads to a segmentation fault in hydro_secretbox, which (unlike hydro_hash) isn't set up to accept NULL key pointers. Passing in a pointer to an array of NULL bytes works for my purposes, but I could submit a patch to hydro_secretbox if this is intended to work.

from libhydrogen.

jedisct1 avatar jedisct1 commented on August 26, 2024

Being able to pass NULL as the master key was not the original intent. But as you asked, I saw that it would be fine with with hydro_hash, but indeed, we need a key for secretbox.

There's no point in trying to encrypt with a predicable key, so we should skip this if a NULL key is provided. This requires changes to all the current functions, but more importantly, I'm not sure that making encryption optional is a good idea.

This in fine for your use case, but in most applications, encryption is useful, even if this is with a static, hard-coded key.

from libhydrogen.

spinda avatar spinda commented on August 26, 2024

Alright! I can definitely understand making it harder to veer away from the known-safe path unless the developer is really sure what they're doing.

from libhydrogen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.