Comments (4)
The AddressCandidateHelper is the is the "helper" that clients can use to convert user-input to actual server addresses. It's a synchronous API and does not make network calls.
The RecommendedServerDiscovery is used to test a list of servers (commonly those outputted from AddressCandidateHelper) by connecting to them and validating the responses.
I would expect the RecommendedServerDiscovery follows redirects and decreases the score slightly (to prefer non-redirected URL's above redirected URL's). The returned RecommendedServerInfo should have a way to indicate it was redirected from the original input, perhaps by adding both the original and final addresses with a getter "isRedirected" that compares them.
The discover function should have a parameter "followRedirects", similar to the option in HttpClientOptions.
from jellyfin-sdk-kotlin.
I'd like to take this.
Just to be clear, when you say the path should be added to the candidates, should that replace the existing candidates so we only check candidates with the redirected path, or should candidates with the path be checked in addition to the existing candidates, possibly with an increased score?
from jellyfin-sdk-kotlin.
Behavior can be tested with our own demo server which redirects to the /stable path.
This doesn't work with the demo site currently as it redirects to stable/web/ instead of just stable/
from jellyfin-sdk-kotlin.
I've been told we're using a baseurl configuration on demo.jellyfin.org so it will indeed redirect to /stable/web/. So it is not suitable to test this behavior with.
from jellyfin-sdk-kotlin.
Related Issues (20)
- how to understand the docs for Jellyfin API HOT 2
- Is permission READ_EXTERNAL_STORAGE required? HOT 1
- Logo doesn't work in documentation with light theme
- TranscodingInfo.TranscodeReasons incorrectly generated HOT 1
- NoClassDefFoundError on API 23 HOT 2
- JsonDecodingException: TranscodeReasons is not a string HOT 5
- Automatically add labels to openapi update pull requests
- Send Message is not getting received on android HOT 4
- Use Duration instead of Long in HttpClientOptions
- Follow HTTP redirect when discovering servers HOT 3
- Reconnect behaviour HOT 3
- Dependency Dashboard
- Two endpoints called every hours HOT 1
- Optimize RegEx validation pattern usage
- SocketInstance / ReconnectHelper can get stuck disconnected HOT 3
- v1.5.0 checklist (Jellyfin 10.9)
- searchApi.getSearchHints indicates an error when SearchHint.matchedTerm is null HOT 4
- Add a third party client (Homedia) HOT 2
- Using client.imageApi.postUserImage reports 400 error HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jellyfin-sdk-kotlin.