Giter VIP home page Giter VIP logo

Comments (4)

nielsvanvelzen avatar nielsvanvelzen commented on July 24, 2024 1

The AddressCandidateHelper is the is the "helper" that clients can use to convert user-input to actual server addresses. It's a synchronous API and does not make network calls.

The RecommendedServerDiscovery is used to test a list of servers (commonly those outputted from AddressCandidateHelper) by connecting to them and validating the responses.

I would expect the RecommendedServerDiscovery follows redirects and decreases the score slightly (to prefer non-redirected URL's above redirected URL's). The returned RecommendedServerInfo should have a way to indicate it was redirected from the original input, perhaps by adding both the original and final addresses with a getter "isRedirected" that compares them.

The discover function should have a parameter "followRedirects", similar to the option in HttpClientOptions.

from jellyfin-sdk-kotlin.

AllegraCodes avatar AllegraCodes commented on July 24, 2024

I'd like to take this.

Just to be clear, when you say the path should be added to the candidates, should that replace the existing candidates so we only check candidates with the redirected path, or should candidates with the path be checked in addition to the existing candidates, possibly with an increased score?

from jellyfin-sdk-kotlin.

AllegraCodes avatar AllegraCodes commented on July 24, 2024

Behavior can be tested with our own demo server which redirects to the /stable path.

This doesn't work with the demo site currently as it redirects to stable/web/ instead of just stable/

from jellyfin-sdk-kotlin.

nielsvanvelzen avatar nielsvanvelzen commented on July 24, 2024

I've been told we're using a baseurl configuration on demo.jellyfin.org so it will indeed redirect to /stable/web/. So it is not suitable to test this behavior with.

from jellyfin-sdk-kotlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.