Giter VIP home page Giter VIP logo

Comments (8)

mfrauenhoffer avatar mfrauenhoffer commented on May 20, 2024 1

Unfortunately, I can't give you the response as it contains company information. I'm more than willing to share any additional information to help you reproduce and debug. Thank you! I love the tool so far!

from nightingale-rest-api-client.

dpaulino avatar dpaulino commented on May 20, 2024

Thanks for reporting this. Out of curiosity, any chance I could get a sample text response that you were expecting back? Or perhaps I could get the endpoint you were using? If not, no worries. I can simulate it based on the size you described. Again, thanks for reporting. Going to investigate this further and report back my findings here.

from nightingale-rest-api-client.

dpaulino avatar dpaulino commented on May 20, 2024

Spent a bit of time reproducing this, and it is indeed similar to the issue that others have reported a few weeks back. Unfortunately no easy fix for this, since it seems that there are currently no UWP text controls capable of handling large text. Here's an issue related to trying to build a scalable text control: CommunityToolkit/WindowsCommunityToolkit#2858

Going to spend some more time on this soon.

from nightingale-rest-api-client.

dpaulino avatar dpaulino commented on May 20, 2024

There's a uservoice request for the platform team to build a UWP control that can handle large strings: https://wpdev.uservoice.com/forums/110705-universal-windows-platform/suggestions/37090696-virtualized-richeditbox

Please help upvote it if you can @mfrauenhoffer. I'll continue to find a workaround for this issue, but a first-party control would be the best long term solution.

from nightingale-rest-api-client.

dpaulino avatar dpaulino commented on May 20, 2024

We have added a fix for the crash. Essentially, we will be checking the size of the response. If it passes 500kb, then we are blocking the rendering of the text. We will provide an option to download the response instead.

While this is not an elegant solution, it should suffice until Nightingale switches to a UI control that can handle large text.

This bug fix will be available in the next update.

For reference, here is a sample URL that previously crashed Nightingale. But the incoming new update no longer crashes: https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/stats/contributors

from nightingale-rest-api-client.

mfrauenhoffer avatar mfrauenhoffer commented on May 20, 2024

Thanks Daniel! I will try it out in the new build. I have also upvoted the UserVoice request as well!

from nightingale-rest-api-client.

dpaulino avatar dpaulino commented on May 20, 2024

No problem. The new build has been deployed to our private preview group. If all goes well, it should be publicly available in a couple days

from nightingale-rest-api-client.

dpaulino avatar dpaulino commented on May 20, 2024

The new build (v2.0.8) is now publicly available.

from nightingale-rest-api-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.