Can GHPRB detect when a commit is no longer on a PR? about ghprb-plugin HOT 5 CLOSED

There are three phases where this plugin is interacting.

1. When the trigger is run or the webhook is triggered.
2. When the build actually starts.
3. When the build finishes.

Your check would be going in when the build starts, to validate that the PR hasn't changed. Unfortunately right now this would be somewhat hard to determine.

Because the build may or may not be using the actual commit, the plugin can't just choose to quit if it no longer matches. The reference to the build also isn't retained once it is scheduled so this would require another change to the plugin.

You are welcome to submit a pull request, or make some more suggestions here and I will get to them in time.

from ghprb-plugin.

Ah, are you saying that in my above scenario:

1. Dev creates PR with commit chain 1
2. GHPRB kicks off job 1 on commit chain 1
3. Dev rebases / force-pushes PR with commit chain 2
4. GHPRB queues up job 2
5. Dev rebases / force-pushes PR with commit chain 3
6. GHPRB queues up job 3
7. Job 1 finally finishes, job 2 starts up

I guess I was assuming that job 2 would test commit chain 2 -- are you saying that job 2 will actually test commit chain 3?

from ghprb-plugin.

Yes. Since the sha1 value is just "origin/pr/" + cause.getPullID() + "/merge" if the PR can be merged, it isn't tied to anything until the git client executes to check out the ref. If you use ghprbActualCommit then it is tied to a commit sha that may/may not exist.

from ghprb-plugin.

Ok. That's probably a bit beyond my Jenkins-foo at the moment. I guess this is best considered a minor optimization -- if someone codes it up someday, that would be great. But it won't be the end of the world if no one does. 😃

from ghprb-plugin.

I just cleaning up some old issues, if this issue is still relevant please reopen.

from ghprb-plugin.