Trigger phrase doesn't accept regexp pattern about ghprb-plugin HOT 8 CLOSED

That is a little misleading. The phrases that it is talking about are:
Add to white list phrase
Accept to test phrase
Test phrase

The trigger phrase is configured in the job config, and you are right, it is not a regex.

from ghprb-plugin.

Ah, I see what the difference is. Is there a reason why the trigger phrase is different?

Would you accept a patch to make it work like the others?

from ghprb-plugin.

Ah, I see what the difference is. Is there a reason why the trigger phrase is different?

It is the result of maintainer merges without keeping uniform configuration in plugin.

from ghprb-plugin.

the only problem with a direct changeover would be that some trigger phrases may have reserved characters. In your pull request if you accommodated that and escaped those trigger phrases I would merge it in.

from ghprb-plugin.

The recent fix works for me most of the time, but every day or so the trigger phrase gets corrupted with extra characters. .ok to simul. becomes \Q.ok to simul.\E. Sometimes there are multiple \Q\Q chars. When this happens, it no longer matches a string like ok to simulate, and we have to go back and edit the job configuration manually to remove the extra chars.

Is this a known issue or some consequence of how it's attempting to sanitize the regular expressions?

from ghprb-plugin.

Fixed in #157

from ghprb-plugin.

@jdonald please open a new issue. In the new issue please post the config.xml configVersion value. It should be three.

from ghprb-plugin.

I have opened #197, and noted there that our configVersion is not 3.

from ghprb-plugin.