[Question/Feature Request] Trigger Matching Branches about ghprb-plugin HOT 18 OPEN

You would do this by using the trigger phrase, and then only building with the trigger

from ghprb-plugin.

That's not something the plugins exposes is it? Ie, it would have to be implemented?

from ghprb-plugin.

There are two settings on the project page for the trigger. They are currently exposed. The trigger phrase is an exact match and didn't use a regex like the test or whitelist phrases.

from ghprb-plugin.

But that matches against a PR comment right?

from ghprb-plugin.

I created a flow job which gets all PR triggers which then triggers the exact PR jobs(while a feature to support this is not implemented).

from ghprb-plugin.

I am guessing I am not understanding what you are looking for then. How would you decide where the job goes? Are you looking for something in the PR description that the trigger would key off of whether to build or not?

from ghprb-plugin.

The ghprb incoming payload includes the pull request id, among other information. My idea was to allow matching job names jobs/foo/bar/{ghPrId}/the-build(this would mean searching for all jobs)...

from ghprb-plugin.

Maybe a better way would be to put a new extension in the trigger that limits the job to triggering certain PR's only? The problem here is that you have to create a new job per pull request right?

from ghprb-plugin.

Yes, I create a "set" of jobs per pull request, see an example here. Each of those jobs has a main-build which should get triggered, but only for the matching PR.

from ghprb-plugin.

Sounds like a whitelist for PR numbers.

from ghprb-plugin.

But that needs to be able to be set on each of the necessary jobs(not just globally)...

from ghprb-plugin.

Is the "Whitelist Target Branches" the implementation of this?

from ghprb-plugin.

Hmm, don't think so, what I need is to white-list the source, not the target....

from ghprb-plugin.

Have gave any thoughts on implementing this?

from ghprb-plugin.

@s0undt3ch I'm helping out with this repo. I do think the whitelisting of branches is the feature you're looking for. If this issue is still relevant to you, could you give that a try?

from ghprb-plugin.

I'm looking at white listing yes, but the source branch, not the destination branch which was what was available last time I looked.

Can we white list the source branch now?

from ghprb-plugin.

Ah, I don't think so. Marking this as an enhancement (but I need to doublecheck, too).

from ghprb-plugin.

Hello
any update on the "Source Branch whitelist" feature?
I could dedicate some time to implement it, do you know if there is ongoing work on it?

from ghprb-plugin.