Giter VIP home page Giter VIP logo

Comments (7)

HughePaul avatar HughePaul commented on August 16, 2024 2

Hi,
Do you know when a new plugin version will be pushed with these changes?
thanks.

from gitlab-hook-plugin.

javiplx avatar javiplx commented on August 16, 2024

I saw #27 which you prompty closed, and I did reopened JENKINS-30861, which basically asked for this feature. Actually, I've seen on your repo that you've already made the username configurable, which is something I wanted to ask for, so the answer is yes, either reopen your previous PR (I cannot) or open a new one.

from gitlab-hook-plugin.

HughePaul avatar HughePaul commented on August 16, 2024

Yes I meant to open a PR to my own fork to get travis running the tests cleanly before doing an upstream PR.
I'll tidy it up and default the username to empty and do a pull request.

from gitlab-hook-plugin.

HughePaul avatar HughePaul commented on August 16, 2024

I'm having problems getting the travis tests to run on ruby versions, it seems to hang.
It completes on the jruby versions.

from gitlab-hook-plugin.

javiplx avatar javiplx commented on August 16, 2024

Recover the ruby tests, and don't worry too much about failures. jruby runs the "unit" tests, but the ruby ones are acceptance tests, and include starting a Jenkins instance. Since a few commits, it tends to constantly timeout on 1.596, but for other Jenkins releases, restarting the job works (sometimes a couple of times).

from gitlab-hook-plugin.

HughePaul avatar HughePaul commented on August 16, 2024

I've changed the travis config back to use ruby and jruby.
I added in some development steps to the readme I was using to download and develop from scratch with no existing dev environment. Let me know if that isn't suitable for a merge to the upstream.

from gitlab-hook-plugin.

HughePaul avatar HughePaul commented on August 16, 2024

the tests are still failing or timing-out in some versions of ruby. The failures don't seem related to any code I've changed.

from gitlab-hook-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.