Giter VIP home page Giter VIP logo

Comments (19)

robertbus avatar robertbus commented on August 16, 2024 4

I can confirm that the plugin does not work with Jenkins 2.0 Pipeline.

Steps to reproduce:

  1. create git repo in GitLab with a Jenkinsfile
  2. configure the 'build_now' webhook triggered by push events in GitLab pointing it to Jenkins
  3. configure a new Pipeline job in Jenkins using above created repo
  4. push some change into GitLab
  5. check Jenkins logs

Expected behavior:

  • webhook triggered by the push and Jenkins building the pipeline project with the new changes

Actual behavior:

  • webhook triggered by the push and Jenkins stating in the logs that it could not find a matching project: "no project references the given repo url and commit branch"

To verify that the plugin works otherwise I also created a freestyle job in Jenkins using the same git repo and a dummy shell step just echoing some text.

Having both jobs (pipeline and freestyle) in Jenkins and pushing changes to the git repo (or clicking on the test hook link in GitLab) leads to the result that the freestyle project build kicks off, but the pipeline one doesn't.

In the logs I could see that Jenkins found only one matching project, the freestyle one.

I hope this helps to pinpoint the cause of this issue.

from gitlab-hook-plugin.

singh-abhijeet avatar singh-abhijeet commented on August 16, 2024 4

Unable to trigger Pipeline Project build on Jenkins 2.7, Pipeline Plugin 2.2, GitLab 7.7.
Jenkins log: No valid crumb was included in request for /github-webhook/. Returning 403.

Tried these URLs, but in vain:

Freestyle project builds fine though.

Note: Disabled Cross Site Forgery security on Jenkins to make it working. Unchecked Manage Jenkins > Configure Global Security > Prevent Cross Site Request Forgery exploits on Jenkins.

from gitlab-hook-plugin.

o8o avatar o8o commented on August 16, 2024 2

I used this URL and it works: http://jenkins host:port/project/my job name

from gitlab-hook-plugin.

chrisjunlee avatar chrisjunlee commented on August 16, 2024

What are the repro steps and expected behavior?

from gitlab-hook-plugin.

amontalban avatar amontalban commented on August 16, 2024

I'm still having this issue:

Feb 24, 2017 7:54:47 PM com.dabsquared.gitlabjenkins.webhook.GitLabWebHook getDynamic
INFO: WebHook called with url: /jenkins/project/Pipeline
Feb 24, 2017 7:54:48 PM org.jruby.javasupport.JavaMethod invokeDirectWithExceptionHandling
INFO: gitlab web hook triggered for
   - repo url: [email protected]:developers/ACME.git
   - branch: pipeline
   - with payload:
{
  "before": "19ed3ef57b7a1b12dbf546649ae61b234d8959fc",
  "after": "c9d3369b5387a9c83c810448ad2854c7d883be9c",
  "ref": "refs/heads/pipeline",
  "user_id": 3,
  "user_name": "Andres Montalban",
  "project_id": 5,
  "repository": {
    "name": "ACME",
    "url": "[email protected]:developers/ACME.git",
    "description": "ACME Core Repository",
    "homepage": "https://git.ACME.com/developers/ACME"
  },
  "commits": [
    {
      "id": "c9d3369b5387a9c83c810448ad2854c7d883be9c",
      "message": "Initial config of Jenkins pipeline",
      "timestamp": "2017-02-24T19:54:40+00:00",
      "url": "https://git.ACME.com/developers/ACME/commit/c9d3369b5387a9c83c810448ad2854c7d883be9c",
      "author": {
        "name": "Andres Montalban",
        "email": "[email protected]"
      }
    }
  ],
  "total_commits_count": 1
}
Feb 24, 2017 7:54:48 PM org.jruby.javasupport.JavaMethod invokeDirectWithExceptionHandling
INFO: matching projects:
   - Checkout_ACME_Repo
Feb 24, 2017 7:54:48 PM org.jruby.javasupport.JavaMethod invokeDirectWithExceptionHandling
WARNING: no project references the given repo url and commit branch

I have two jobs Checkout_ACME_Repo (FreeStyle) and Pipeline (Pipeline), but only former is matching.

from gitlab-hook-plugin.

vkotovv avatar vkotovv commented on August 16, 2024

@singh-abhijeet is this hook working with pipelines if you disable Cross Site Forgery security as you said?

from gitlab-hook-plugin.

singh-abhijeet avatar singh-abhijeet commented on August 16, 2024

@vkotovv Yes Vadim, the 403 error was due to Cross Site (Domain) request to the Web Hook. Disabling the security option helped. This solution is advisable if you're running Jenkins, Git within your org's Firewall; as disabling it can invite False/Forgery request to the Web Hook if your Jenkins instance is exposed publicly via Internet.

from gitlab-hook-plugin.

leti-ulloa avatar leti-ulloa commented on August 16, 2024

I'm having the same problem originally reported.. the web hook works fine on a freestyle project but does not work in pipeline project.. Has anyone found a workaround for this?

from gitlab-hook-plugin.

bmaehr avatar bmaehr commented on August 16, 2024

It is still not working with Pipeline-Projekts.

from gitlab-hook-plugin.

colinlabs avatar colinlabs commented on August 16, 2024

@bmaehr thanks, I had build successfully, it's docker image's problem, your PR work well in my machine,support 2.0 pipeline web hook and system hook . @javiplx , can you merge this PR to master branch?

from gitlab-hook-plugin.

ikus060 avatar ikus060 commented on August 16, 2024

Is this issue fixed with the previous PR ?

from gitlab-hook-plugin.

bmaehr avatar bmaehr commented on August 16, 2024

My commit should fix it, but I also don't understand @colinlabs comment.

from gitlab-hook-plugin.

colinlabs avatar colinlabs commented on August 16, 2024

@bmaehr it works, but there is a problem, must success run a job before trigger hook

from gitlab-hook-plugin.

ikus060 avatar ikus060 commented on August 16, 2024

@colinlabs You mean: a job must run successfully to make the web hook work ?

from gitlab-hook-plugin.

colinlabs avatar colinlabs commented on August 16, 2024

@ikus060 yes, otherwise, it will raise an "Template not find" error

from gitlab-hook-plugin.

bmaehr avatar bmaehr commented on August 16, 2024

I think it is enough that the template has run once.

from gitlab-hook-plugin.

ezraroi avatar ezraroi commented on August 16, 2024

he, any update on this? looks like the PR was never merged.... for me it is not working even when the pipeline ran once

from gitlab-hook-plugin.

javiplx avatar javiplx commented on August 16, 2024

It looks like I didn't notice the notification about #55. I need to arrange it to execute tests to ensure that it does not break something, as happened with javiplx#100

from gitlab-hook-plugin.

ezraroi avatar ezraroi commented on August 16, 2024

@javiplx so we can expect to get a new version with this feature?

from gitlab-hook-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.