Build is kicked off after a merge request is accepted about gitlab-plugin HOT 20 CLOSED

Jenkins 1.565.2
GitLab Plugin 1.1.1
GitLab 7.2.1

Gitlab config:

• Webhook on Merge Requests Events https://jenkins/project/mergereq-behave-byoptimizer
• Gitlab CI Service https://jenkins/project/mergereq-behave-byoptimizer

Jenkins job mergereq-behave-byoptimizer

• Build on Push Events
• Build on Merge Request Events

from gitlab-plugin.

@loa does your configuration work or do you have the same issue?

My setup is:
Jenkins 1.580
GitLab Plugin 1.1.3
GitLab 7.2

from gitlab-plugin.

@jchristi I have the same issue.

from gitlab-plugin.

Ok it looks like what is happening, is gitlab sends a merge request event when the merge is closed. Because of this the gitlab-plugin is not filtering out the closed events. it would seem like this line: https://github.com/DABSquared/gitlab-plugin/blob/master/src/main/java/com/dabsquared/gitlabjenkins/GitLabWebHook.java#L317 Is not filtering correctly, possibly because the gitlab api changed or is not sending the right status as I have seen inconsistencies with the api vs. the documentation before.

from gitlab-plugin.

With Gitlab 7.3, I get this json : https://gist.github.com/notFloran/a5147f558465ebcec552

from gitlab-plugin.

nice, so just adjusting the filter should do the job. Thanks!

from gitlab-plugin.

A merge request can be closed without being merged, so I assume both of these values are possible.

from gitlab-plugin.

..but a build is not needed any longer so we can safely filter it out.

from gitlab-plugin.

In both cases it should be filtered, whether merged or closed (but not merged).

from gitlab-plugin.

@bassrock awesome, thanks :D

from gitlab-plugin.

Good to see it's getting fixed. Had the same issue. Thanks!

from gitlab-plugin.

Accepting a merge does not trigger a build for the merge request event anymore. However, it means that the changes are pushed to the target branch (which subsequently triggers a build). The question is, is this desirable or not? Should we also filter out this build?

from gitlab-plugin.

@xaniasd I would say that is the correct behavior, because technically a commit and push did happen to the target branch and a user could have scripts meant to run to deploy if its a merge from say bug fix to development.

from gitlab-plugin.

please disregard last comment, wrong commit message :)

from gitlab-plugin.

tested this, seems to be fixed

from gitlab-plugin.

all, is this resolved with the latest version of the plugin? can I close the issue?

from gitlab-plugin.

@xaniasd I will test with the latest plugin when I get the chance

from gitlab-plugin.

@jchristi is this still an issue?

from gitlab-plugin.

Closing do to no comments. Please comment to reopen if it is still an issue.

from gitlab-plugin.

I see the behavior the OP described and it causes the job to fail when the source branch has been deleted.

GitLab: 7.11.4
Jenkins: 1.580.1
GitLab Plugin: 1.1.23

from gitlab-plugin.