Giter VIP home page Giter VIP logo

Comments (7)

evictor avatar evictor commented on August 16, 2024 2

Thanks for the note. Is it safe to say the blanket disabling is just a band-aid and a patch should still be made so the plugin itself can handle the reconfiguration?

from scm-sync-configuration-plugin.

m-bucher avatar m-bucher commented on August 16, 2024

Same here on Jenkins 2.138.3 and Plugin version 0.0.10 (also tried 0.0.9)
Looks like the HTML has '<' HTML-encoded:
&lt;br/>To remove this message, please &lt;a href='#' onclick='javascript:removeLog();'>click here&lt;/a>

from scm-sync-configuration-plugin.

evictor avatar evictor commented on August 16, 2024

Bit more than cosmetic because it also covers the last bits of console output, which are often the most important. :(

Thx for reading

from scm-sync-configuration-plugin.

amandel avatar amandel commented on August 16, 2024

You need to set -Dorg.kohsuke.stapler.jelly.CustomJellyContext.escapeByDefault=false which helps in this case. There are several things broken with this change in Jenkins. See https://jenkins.io/blog/2018/10/10/security-updates/ and https://wiki.jenkins.io/display/JENKINS/Plugins+affected+by+2018-10-10+Stapler+security+hardening

from scm-sync-configuration-plugin.

mikemol avatar mikemol commented on August 16, 2024

Indeed, it would be really nice if the plugin could be targeted about disabling the escaping logic.

from scm-sync-configuration-plugin.

jeinstei avatar jeinstei commented on August 16, 2024

Same issue, just to report it. It looks like the j:set var="msg" block creates a commented out span, and not what the code is expecting.

from scm-sync-configuration-plugin.

aba-rechsteiner avatar aba-rechsteiner commented on August 16, 2024

+1

from scm-sync-configuration-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.