Giter VIP home page Giter VIP logo

Comments (7)

proski avatar proski commented on August 13, 2024 2

The general question for pre-build state is that what to do with job state if it was cancelled. No one status represent this situation. Currently I see no option to unmark the state.

Canceling the build from the queue is not much different from aborting the build during the first second. The build has not completed, and will not complete, but the code under test is not to blame.

Abort marks the build as FAILED, and so should the cancel. That's not optimal, obviously, but far better than reporting SUCCESS (which could allow merging untested code) or INPROGRESS (which could make the user wait for the results instead of taking action).

We could ask Atlassian to add more codes in the future versions.

In the meantime, maybe the detailed status could be added to the message, e.g. cancelled by Jenkins @ http://jenkins/ or aborted by Jenkins @ http://jenkins/

For matrix builds that report results from the child jobs only, nothing needs to be reported on cancel.

from stashnotifier-plugin.

scaytrase avatar scaytrase commented on August 13, 2024

Current Stash API knows only three statuses

"state": "<INPROGRESS|SUCCESSFUL|FAILED>",

As the build step there is nothing to do with these ones as they triggered only at the time the job actually starts.

The internet says that BuildWrapper could be implemented, but this a kind of research for me.

from stashnotifier-plugin.

jeff-minard-ck avatar jeff-minard-ck commented on August 13, 2024

Yeah, I want to set state=inprogress over at stash when the job call is received as jenkins not when job actually starts building. This way when there's a long queue, stash will show that the build has "started" (effectively been queued up to run).

from stashnotifier-plugin.

byF avatar byF commented on August 13, 2024

This is actually a bug; once a job is in a queue, it should be marked as pending in Stash.

There is an option to use BuildWrapper (I'm not sure I understand well what the class does though) or to use QueueListener. Either case, this will require quite extensive decomposition of StashNotifier class.

It might be also interesting to go completely in the way of Listeners (i.e. use BuildStepListener instead of Notifier) and rewrite the plugin completely.

from stashnotifier-plugin.

scaytrase avatar scaytrase commented on August 13, 2024

Decomposition is an option. I hope I'll get this and start 2.0 branch sometimes

from stashnotifier-plugin.

scaytrase avatar scaytrase commented on August 13, 2024

The general question for pre-build state is that what to do with job state if it was cancelled. No one status represent this situation. Currently I see no option to unmark the state.

Until we have a decision - pre-build notifying is not an option

from stashnotifier-plugin.

IanKL avatar IanKL commented on August 13, 2024

I've created a request to add options including QUEUED to the BuildState enum: https://jira.atlassian.com/browse/BSERV-13304

from stashnotifier-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.