{* *} Comments not highlighted in the syntax about vscode-smarty HOT 8 OPEN

@jens1o You can compare (with diff) both files and then try to figure out the most important differences. As I looked now - there aren't so many of them.

Anyway, it seems that original file in this repository comes from the same place as I mentioned so I don't see a big problem to replace it... And also as far as I have used the replaced file for almost a week I haven't noticed this comment problem again or other issues.

from vscode-smarty.

Hi, how would you expect it different?

from vscode-smarty.

That's how I would like it to look.
This is what it's doing right now.

I think an embedded CSS comment might be throwing the syntax off?

from vscode-smarty.

Could you please provide the full file? Or at least a file you can reproduce with(which you created for this issue), so I can fix it?

from vscode-smarty.

^ Here is one possible example... It happens because of "<" symbol in if operator...

from vscode-smarty.

I am not sure that this fully solves all problems and/or don't introduce new but one solution is to replace syntaxes/smarty.tmLanguage with this file: https://github.com/textmate/php-smarty.tmbundle/blob/master/Syntaxes/Smarty.plist - then everything seems to work fine.

It would be nice if @jens1o could check this and update extension if needed.

from vscode-smarty.

@arvislacis I'm fine with a pull request, but I would prefer not to replace a file, but to actuaally fix the problem. :/

from vscode-smarty.

Perfect! Thanks for your investigations :)

from vscode-smarty.