Comments (11)
This is now patched in notmuch and it'll be in the next release, thanks @runekaagaard! This issue can be closed.
from org-msg.
I think it should go into notmuch-company
as that's where the restriction happens. The code you wrote seems fine for a contribution to that package. As it stands, org-msg and notmuch are working happily together on my system with #49 and there isn't an interference with notmuch address completion.
from org-msg.
Guess you are right. I'm on outlook, not google so your solution at #49 does not apply to me.
from org-msg.
I should say that my comment in the other thread is just for an address source, and there are other options for notmuch. Have you looked through notmuch-address.el? Perhaps you'll find useful avenues to explore there.
from org-msg.
@runekaagaard This is really hacky but I use this to get past this issue:
(defun arvindsv/org-msg-notmuch-company (old-fn &rest args)
;; Cheat and say that this buffer, which should be org-msg-edit-mode, is derived from message-mode.
(cl-letf (((symbol-function 'derived-mode-p) (lambda (mode) (if (eq mode 'message-mode) t (derived-mode-p mode)))))
(apply old-fn args)))
(advice-add 'notmuch-company :around #'arvindsv/org-msg-notmuch-company)
from org-msg.
@arvindsv Heh, Thats great, thx!!
from org-msg.
@runekaagaard This is really hacky but I use this to get past this issue:
(defun arvindsv/org-msg-notmuch-company (old-fn &rest args) ;; Cheat and say that this buffer, which should be org-msg-edit-mode, is derived from message-mode. (cl-letf (((symbol-function 'derived-mode-p) (lambda (mode) (if (eq mode 'message-mode) t (derived-mode-p mode))))) (apply old-fn args))) (advice-add 'notmuch-company :around #'arvindsv/org-msg-notmuch-company)
With this, I'm getting Company: backend company-capf error "Lisp nesting exceeds ‘max-lisp-eval-depth’" with args (prefix)
Any ideas why that would be?
And perhaps a slightly less hacky version (which has the same issue as above) is to add org-msg-edit-mode to the derived-mode list.
(put 'org-msg-edit-mode 'derived-mode-parent 'message-mode)
But, having said that, it doesn't work :)
from org-msg.
@Joshuao95, I suspect that you might have not set notmuch-company
as a backend for org-msg-edit-mode
, not the notmuch-message-mode
, which the the default one. After setting it properly, and with your suggested tweak, I achieved posed desirable behavior. Maybe it is worth to try.
from org-msg.
@HyunggyuJang Perfect, thanks a lot, that solves it for me too
from org-msg.
@Joshuao95 ;)
from org-msg.
Beautiful!
from org-msg.
Related Issues (20)
- Odd Issue with Forwarded Messages, Empty Message at Top
- Tab does not auto-complete emails in the To: field HOT 15
- Wrong cursor position after reply — missing call to `goto-body` HOT 1
- Unwanted *ORG ASCII Export* buffer HOT 5
- Forwarding email with inline image or LaTeX formula fails (reverts to text), but replying works (keeps html) HOT 1
- Customise reply/forward citation lines (currently sometimes shows several authors in From: and duplicate authors in Cc:)
- Temporary reply-to filepaths are not persisted HOT 1
- Proper way to inject css
- Documentation for org-msg-options HOT 1
- `mu` v1.11.23 breaks `org-msg` HOT 3
- inline images in parent message have the wrong content-disposition (attached) when replying HOT 1
- [Feature Request] Addressee tagging generating a mailto link in the message body HOT 2
- How to disable org-msg for org-submit-bug-report?
- `mu 1.12.0` breaks `org-msg` HOT 34
- compose error with mu4e HOT 3
- adding courier font command HOT 4
- when I edit a draft and send -- the email isn't converted to html
- [Feature]: Preview includes the original message when forwarding
- Cannot get proselint to load as checker HOT 1
- org-msg-edit-mode-mu4e: Symbol’s function definition is void: mu4e~compose-remap-faces
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from org-msg.