Giter VIP home page Giter VIP logo

Comments (16)

karlerik-simon avatar karlerik-simon commented on August 23, 2024 2

Perfect! No problem, thanks for assigning the issue to me

from chitchatter.

dillfrescott avatar dillfrescott commented on August 23, 2024 1

Oh awesome! I'm glad you like the idea! Im in no hurry so you can add it whenever you feel like it!

from chitchatter.

karlerik-simon avatar karlerik-simon commented on August 23, 2024 1

I can have my go at it, see if I'm able to do much

from chitchatter.

dillfrescott avatar dillfrescott commented on August 23, 2024 1

Please dont make me rush you guys. Id just love to see it as a feature is all!

from chitchatter.

jeremyckahn avatar jeremyckahn commented on August 23, 2024

Hi @dillfrescott, right now this functionality is not supported. I consider the lack of name customization a security feature, as it should help to prevent users from impersonating others. This might be revisited if Chitchatter ever supports a way to host "personal" rooms (where one peer has administrative rights that other peers don't), but for now I'd like to keep this functionality out of the project.

from chitchatter.

dillfrescott avatar dillfrescott commented on August 23, 2024

Gotcha. I understand

from chitchatter.

dillfrescott avatar dillfrescott commented on August 23, 2024

Wait I did think of something. Maybe just a "display name" that can be set, but a randomized handle you cant change, that way even if someone sets their name as someone else, you can still tell its a different person by the handle.

from chitchatter.

jeremyckahn avatar jeremyckahn commented on August 23, 2024

I think that would make sense. We could have an "alias" that users can customize, but the static friendly animal name could still show alongside it. Perhaps something like this:

User alias mockup

I think that would be a good addition. I'll reopen this ticket!

from chitchatter.

jeremyckahn avatar jeremyckahn commented on August 23, 2024

@dillfrescott I won't have availability to work on this until next month at the earliest, so let me know if you'd like to pick this up.

from chitchatter.

jeremyckahn avatar jeremyckahn commented on August 23, 2024

@karlerik-simon thanks for offering to pick this up! Feel free to open a PR and I'll help you get it merged. I'll assign this issue to you. Let me know if you need any help!

from chitchatter.

dillfrescott avatar dillfrescott commented on August 23, 2024

@jeremyckahn this is the only other thing I can think of adding that would really make it perfect!

from chitchatter.

jeremyckahn avatar jeremyckahn commented on August 23, 2024

@karlerik-simon have you made much progress with this feature? If not, would you mind if I reassigned this issue to myself? It looks like @dillfrescott would really like to see this implemented and I've got some bandwidth to work on it now.

from chitchatter.

dillfrescott avatar dillfrescott commented on August 23, 2024

@jeremyckahn I was testing the name change branch and it works great! I do think there should be a setting to remember your chosen nickname across rooms though. Just so one doesn't have to type it in for every room they join if they so desire!

from chitchatter.

jeremyckahn avatar jeremyckahn commented on August 23, 2024

@dillfrescott good idea! I agree. 🙂 FWIW, the name change work is still in development and there are still some kinks to work out. It should at least be stable, if incomplete. Please let me know if you run into any crashes or instability in your testing!

from chitchatter.

dillfrescott avatar dillfrescott commented on August 23, 2024

@jeremyckahn Will do! Thank you!

from chitchatter.

jeremyckahn avatar jeremyckahn commented on August 23, 2024

@dillfrescott This is done and deploying now: https://github.com/jeremyckahn/chitchatter/actions/runs/4332396581

Let me know how you like it!

from chitchatter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.