Conversion problem with toRomaji function about kana_kit HOT 3 OPEN

Hey there,

Thanks for opening this issue. Looks great! I'll quickly try it myself later today, and fix the pub CI pipelines and tests in the meantime 👍🏻

from kana_kit.

I created a (hopefully) simple fix. I added a check above line 59 of the conversions.dart.

// Ensure 'ヮー' => 'ゎー' become 'waa'
if (previousKana == 'ゎ' && char == 'ー') {
  hiraChars.removeLast();
  hiraChars.addAll(['わ', 'あ']);
  continue;
}

It now converts 'シークヮーサー' to 'shiikuwaasaa' and 'シマウヮー' to 'shimauwaa' which seems correct to me (and for what it's worth Google Translate's pronunciation also does an extended vowel wa).

I tested this on my own and it doesn't seem to mess with any other conversions. Although I wasn't able to run the test suite because pub is having trouble resolving the dependencies.

@jeroen-meijer What do you think of this change? If it looks okay I can create a PR. If not, do you have a different solution in mind?

from kana_kit.

Just a ping to see if this will make it in.

from kana_kit.