Canvas/table id about jquery-qrcode HOT 3 OPEN

can you do a pull request ? and make the id optional in the options. an hardcoded value wont be too flexible

from jquery-qrcode.

Oh...right. my bad. I agree completely. I was thinking *default values when I typed in the field and meant to show that as an option instead of the fixed value, where the option would be "container_id" or something along those lines.

30 canvas.id = options.container_id

~line 12 container_id : 'qrCode' (or similar generic default identifier)

and the table looks like it would be fixed by simply appending an attr() call to the end of the css sets

(starting around line 59)
var $table = $('<.table></.table>')
.css("width", options.width+"px")
.css("height", options.height+"px")
.css("border", "0px")
.css("border-collapse", "collapse")
.css('background-color', options.background)

                   .attr('id', options.container_id);

If by pull request you mean for me to change the code and upload back here, I'd be glad to, but I'm kinda newbishly clueless on the collaboration process, (team of one for the most part) so I really don't know how to accomplish it correctly, although willing to learn. If you simply meant for me to grab the source, I have it and have made the changes locally.

from jquery-qrcode.

pull request is the way to contribute code on github. you can have more doc here http://help.github.com/send-pull-requests/

from jquery-qrcode.