Comments (7)
Would be nice if you can focus on the diff window and then not use FN tho.
from lazygit.
I'm gonna close this issue because we now support scrolling with ctrl+u/d and configurable scroll distance, but I'll open a new issue for your comment @OGKevin because I agree we should have that as a feature
from lazygit.
@OGKevin agreed. If somebody could put up a PR having a go at that, would be much appreciated!
from lazygit.
I tried ctrl + u and ctrl + d for scrolling up and down in a vim fashion, would love to have that but I don't have any experience with go. Configurable key bindings would solve it though!
from lazygit.
@jesseduffield I forked and did this for my own use but I take it you wouldn't accept a PR with just a duplicate key binding?
diff --git a/keybindings.go b/keybindings.go
index afaa095..e789dc8 100644
--- a/keybindings.go
+++ b/keybindings.go
@@ -16,6 +16,8 @@ func keybindings(g *gocui.Gui) error {
bindings := []Binding{
{ViewName: "", Key: 'q', Modifier: gocui.ModNone, Handler: quit},
{ViewName: "", Key: gocui.KeyCtrlC, Modifier: gocui.ModNone, Handler: quit},
+ {ViewName: "", Key: gocui.KeyCtrlU, Modifier: gocui.ModNone, Handler: scrollUpMain},
+ {ViewName: "", Key: gocui.KeyCtrlD, Modifier: gocui.ModNone, Handler: scrollDownMain},
{ViewName: "", Key: gocui.KeyPgup, Modifier: gocui.ModNone, Handler: scrollUpMain},
{ViewName: "", Key: gocui.KeyPgdn, Modifier: gocui.ModNone, Handler: scrollDownMain},
{ViewName: "", Key: 'P', Modifier: gocui.ModNone, Handler: pushFiles},
from lazygit.
god DAMN I did not know you could do ctrl keys like that, I assumed you could only add that via the modifier part which only supports cmd.
Given that we already have vim hjkl keybindings by default I'm happy to merge this in as well. But just before I do, Are we sure that c-u and c-d are the most appropriate vim keys? This comment states that c-p and c-n make sense. If you think so, I'm happy to merge the PR
from lazygit.
Haha nice!
I haven't mastered vim but Ctrl+n and Ctrl+p are often for going up and down a list of selectables, and the author of that other issue suggests it for scrolling through the list of files, for which you already put in h j k l.
The biggest pitch for Ctrl+d and Ctrl+u I should've mentioned is that those keybindings can be used to scroll when you type git diff
in the terminal :)
Alright I'll make a PR but it would also be nice if we could mimic the git diff behavior even better by making it scroll several lines per key stroke instead of just one. I couldn't figure out the handlers when I messed around. But this doesn't go for just Ctrl+d and Ctrl+u but fn+up and fn+down as well.
from lazygit.
Related Issues (20)
- Editing a gpg signed commit message via a Editor crashes HOT 1
- Better global error handling
- Unable to update lazygit - Invalid cross-device link
- Possible memory leak HOT 1
- Installing Lazygit with Go, dependency download failed HOT 4
- Jittering and laggy scrolling in the latest version HOT 1
- lazygit is not starting HOT 2
- crash if opened from a .git folder
- Additional reset shortcut HOT 3
- Lazygit crashed on adding github SSH remote HOT 1
- error "expected section name" HOT 3
- Emoji in commit log cause extra characters right after the emoji HOT 1
- Disable split when Staged/Unstaged is empty HOT 1
- externalDiffCommand doesn't work when diffing between 2 refs HOT 2
- PowerShell's limitation on 4bit basic 16 colours
- Nil pointer on *RemoteBranch.FullName
- Error when creating Pull Requests with Bitbucket HOT 1
- Cannot moving commit in tmux HOT 7
- Tell Lazygit not to set the terminal title HOT 1
- Lazygit hangs terminal on listing commits HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lazygit.