Comments (6)
As soon as the build in your PR is done I will merge this.
from payment.
Thanks for the fast response. Unfortunately, Travis CI appears to be stuck.
from payment.
Yeah and the Merge button is disabled until the Travis Build finishes. maybe @jessepollak can turn off the requirement for the Travis build to complete before we can merge?
from payment.
Looks like a unit test failed
from payment.
I looked into it. The reason is because PhantomJS, which is used in the tests, is ancient and unmaintained. It doesn't know about globalThis
. But globalThis
does have great support in real environments, going all the way back to Node 12 and Chrome 71, which came out more than two years ago.
The change should be extremely safe and backwards compatible, that's why I chose that approach.
I could attempt to modernize the testing infrastructure in this project, although I'm not familiar with CoffeeScript.
from payment.
Well the "Merge" button is locked out on me because the tests are passing. It will only let me Merge once the build succeeds. But I don't want to comment out all tests. Hmmm.
from payment.
Related Issues (20)
- Diners club cards format as Visa HOT 3
- Troy Credit Card Support HOT 5
- Maximum call stach execution HOT 1
- Overrides global Payment HOT 1
- JCB regex wrong HOT 3
- The length of the visa card is 13, 16, please update HOT 5
- format credit card number after Autofill HOT 12
- Payment don't work with jest HOT 5
- Provide function to remove listeners from a input HOT 1
- iOS class="cc-number" HOT 18
- Trying to get in touch regarding a security issue HOT 6
- Strange CC editing behavior
- Old elo's pattern HOT 3
- "jasmine index.spec.js" result => Reference Error: document is not defined HOT 1
- Payment.fns.restrictNumeric is not a function- should it be Payment.restrictNumeric?
- Payment.J is undefined HOT 3
- DOM-free version?
- Discover and JCB can also be 19 characters long HOT 2
- On Copy Paste card is not autoformatting. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from payment.