ReferenceError: global is not defined about payment HOT 6 CLOSED

As soon as the build in your PR is done I will merge this.

from payment.

Thanks for the fast response. Unfortunately, Travis CI appears to be stuck.

from payment.

Yeah and the Merge button is disabled until the Travis Build finishes. maybe @jessepollak can turn off the requirement for the Travis build to complete before we can merge?

from payment.

Looks like a unit test failed

from payment.

I looked into it. The reason is because PhantomJS, which is used in the tests, is ancient and unmaintained. It doesn't know about globalThis. But globalThis does have great support in real environments, going all the way back to Node 12 and Chrome 71, which came out more than two years ago.

The change should be extremely safe and backwards compatible, that's why I chose that approach.

I could attempt to modernize the testing infrastructure in this project, although I'm not familiar with CoffeeScript.

from payment.

Well the "Merge" button is locked out on me because the tests are passing. It will only let me Merge once the build succeeds. But I don't want to comment out all tests. Hmmm.

from payment.