Comments (3)
Thanks for getting in touch. Let me summarize my thoughts from our DM here.
suggestion would be remove the fallback on LocalViewModelStoreOwner for KMP targets (jbMain)
I believe this should be the same across the platforms
This is where it depends on Compose UI
Yes, but Android depends on UI only in similar line too.
I don't see why it can't have dependency in viewmodel-compose
This module will bring dependency not only to itself - it has dependencies that UI doesn't. We'd like to avoid extra dependencies in Compose UI module.
My suggestion here is to open an issue in Google's tracker and try to do such a revert in AOSP first.
I already made this change for compose-ui and lifecycle-compose for the same reason, so I suspect a similar change could be made here.
Yep, thanks for that. But I guess there the situation is a bit different - it really depends on UI part in terms of finding UI view as default provider. My best guess here at the moment is to extract the required part rom ui
to separate ui-something
module and depend only on that.
Anyway, I'm going to close it as not planned for now, since I believe that it should be done in AOSP first. Please post a link to the issue in AOSP once created.
from compose-multiplatform.
@DevSrSouza, could you please open an issue in our AOSP lifecycle issue tracker so we can investigate this further? Please cross-link both issues for additional context and easier tracking. Thank you!
from compose-multiplatform.
The dependency between compose-ui and viewmodel-compose should likely be inverted. I already made this change for compose-ui and lifecycle-compose for the same reason, so I suspect a similar change could be made here.
from compose-multiplatform.
Related Issues (20)
- Generate XCFramework with UI, resources and dependencies HOT 2
- Kotlin/Wasm responsive layout HOT 7
- Support text hyphenation HOT 1
- How to monitor finger position like touch_down\touch_move on Android platform?
- Brush.linearGradient don't work HOT 1
- Order of accessibility nodes is wrong HOT 1
- When targeting Android for a KMP project using `Coil 3.0.0-alpha06`, attempting to use `.toBitmap()` and `.asComposeImageBitmap()` results in `Unresolved reference` HOT 2
- Consider removing `Unconfined` dispatcher as default `CoroutineContext` for `ComposeScene` creation HOT 1
- Consider adding a boolean to disable `GlobalSnapshotManager.ensureStarted()` call during scene creation
- PressInteraction.Cancel is sent on mouse press and drag outside surface HOT 1
- Are there any good suggestions about using compose to generate UI through drag and drop and output the code to the local? HOT 5
- Erratic window focus behavior HOT 1
- `delay` is not respected with `runComposeUiTest` HOT 1
- compile WasmJs FAILED HOT 2
- [Regression] - running iOSApp fails with 1.6.10-rc02 HOT 18
- CI build task failed after import WASM/JS target HOT 4
- Make the generated resource accessors public HOT 2
- Build failed when building native macOS app after added compose resources. HOT 1
- Encountered error after upgrading from 1.6.10-beta01 to 1.6.10-rc01 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compose-multiplatform.