Search event should only fire upon a change of text in search box about chorus HOT 6 CLOSED

Hows this for a solution...
While the search box has focus, detecting if CTRL/CMD (or ALT) is depressed and ignore it and any other key presses while it is. Unless anyone can think of a more elegant solution?

from chorus.

Would it not work to simply use something like jquery's .change() ? http://api.jquery.com/change/

Or is that what's already being used, and it's buggy? :)

from chorus.

Using keyup() I think, so change() might actually solve it! Good call.
There is some other logic wrapped around it too, ie. a timeout so it doesn't try to search for about a second after typing has stopped, but that should still work with change()

from chorus.

Although, I just noticed this after posting my comment:

or select boxes, checkboxes, and radio buttons, the event is fired immediately when the user makes a selection with the mouse, but for the other element types the event is deferred until the element loses focus.

So, i guess this is why keyup() is used instead of change. Ugh.

I guess we could do something like fire on keyup, and the function that's fired checks for a change in the value of the dom element. Already getting very complicated, though.

An alternative is to use .on('input'), which is apparently only available on "modern browsers" (but that's already a requirement for chorus). Here's an example - http://jsfiddle.net/K682b/6/ . I tested it, and the event fires on changes, but not on pressing the modifier keys, so it seems perfect..

from chorus.

Yeah just tested it and change() is a no-go.
.on('input') looks like a winner. And yes, there is no good reason someone should be running an old browser these days :)
I'll do some more testing but if all good, I think we have our solution!

from chorus.

Updated in 0.3.9, tested well for me, re-open if any issues

from chorus.