Comments (1)
@Jerry4013,
Thanks for reporting this issue!
Pong returned only if the ping succeeded.
False returned when there was an error.
Here is the ping function: https://github.com/jfrog/xray-client-js/blob/master/src/SystemClient.ts#L10
try {
return await this.httpClient.doRequest(requestParams);
} catch (error) {
return false;
}
In order to support your use case and throw errors, we should remove the try-catch clause and modify the tests respectfully.
Would you like to contribute code that removing the try-catch?
By the way, you can find in the tests many examples for ping commands: https://github.com/jfrog/xray-client-js/blob/master/test/SystemClient.spec.ts#L28.
from jfrog-client-js.
Related Issues (8)
- ECONNREFUSED when using URL without https/http prefix HOT 1
- cannot download binary artifact using download().downloadArtifact()? HOT 4
- add download as stream functionallity HOT 1
- add upload to artifactory from file or stream HOT 3
- add functionality to list all artifacts at a given path
- Wrong type for downloadArtifact
- Axios outdated. Please bump. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jfrog-client-js.