jfrog/setup-jfrog-cli@v2 breaking change in move from node12 to node16 about setup-jfrog-cli HOT 7 CLOSED

@yahavi If you can please take a look, I'd appreciate it a great deal.

from setup-jfrog-cli.

Thanks for reporting this issue @justfalter!
Till we roll back to node 12, will you be able to use jfrog/[email protected] instead of jfrog/setup-jfrog-cli@v2?

from setup-jfrog-cli.

@justfalter,
Node 12 is under end-of-life since April 30th, 2022. It will not receive any security updates from now and therefore it is a security risk to keep using it. Please accept my apologies for not adding node16 to the release notes, I added it now.

You can keep using 2.1.0 with the latest JFrog CLI:

- uses: jfrog/[email protected]
  with:
    version: latest

Or with a specific version:

- uses: jfrog/[email protected]
  with:
    version: 2.14.0

Please let us know what do you think.

from setup-jfrog-cli.

What’s the versioning policy for this repository?

I am aware that node12 is EOL, but that’s not a good reason to include a breaking change in a minor revision. If it is to adhere to semantic versioning, then the breaking change necessitates a major rev. That’s why pretty much all of the “actions*” repositories rev’d their major version numbers within the last month.

from setup-jfrog-cli.

@justfalter,
@yahavi and I discussed this, and both of us think that you're right. Minor versions shouldn't include breaking changes. It looks like we under estimated the impact of the node version upgrade.
We'll do as you suggested - release another minor for v2 with a rollback of the node upgrade, and release v3 with node 16. We'll share an update here once done.
Thanks again for sharing your feedback and for using this Action. We truly appreciate it.

from setup-jfrog-cli.

No worries! The feature timeline for GitHub Enterprise is delayed when compared to GitHub.com, and really only GHE customers are aware of the difference.

GitHub could do a better job of informing the Actions authors about these things. I’ve run into a couple other actions that did the same node12 to node16 without the major rev, so it’s an honest mistake.

Thanks!

from setup-jfrog-cli.

@justfalter
Setup JFrog CLI 2.2.1 is released. This version includes the node16->node12 change.
We'd appreciate your feedback on that.

from setup-jfrog-cli.