Comments (7)
@yahavi If you can please take a look, I'd appreciate it a great deal.
from setup-jfrog-cli.
Thanks for reporting this issue @justfalter!
Till we roll back to node 12, will you be able to use jfrog/[email protected]
instead of jfrog/setup-jfrog-cli@v2
?
from setup-jfrog-cli.
@justfalter,
Node 12 is under end-of-life since April 30th, 2022. It will not receive any security updates from now and therefore it is a security risk to keep using it. Please accept my apologies for not adding node16 to the release notes, I added it now.
You can keep using 2.1.0 with the latest JFrog CLI:
- uses: jfrog/[email protected]
with:
version: latest
Or with a specific version:
- uses: jfrog/[email protected]
with:
version: 2.14.0
Please let us know what do you think.
from setup-jfrog-cli.
What’s the versioning policy for this repository?
I am aware that node12 is EOL, but that’s not a good reason to include a breaking change in a minor revision. If it is to adhere to semantic versioning, then the breaking change necessitates a major rev. That’s why pretty much all of the “actions*” repositories rev’d their major version numbers within the last month.
from setup-jfrog-cli.
@justfalter,
@yahavi and I discussed this, and both of us think that you're right. Minor versions shouldn't include breaking changes. It looks like we under estimated the impact of the node version upgrade.
We'll do as you suggested - release another minor for v2 with a rollback of the node upgrade, and release v3 with node 16. We'll share an update here once done.
Thanks again for sharing your feedback and for using this Action. We truly appreciate it.
from setup-jfrog-cli.
No worries! The feature timeline for GitHub Enterprise is delayed when compared to GitHub.com, and really only GHE customers are aware of the difference.
GitHub could do a better job of informing the Actions authors about these things. I’ve run into a couple other actions that did the same node12 to node16 without the major rev, so it’s an honest mistake.
Thanks!
from setup-jfrog-cli.
@justfalter
Setup JFrog CLI 2.2.1 is released. This version includes the node16->node12 change.
We'd appreciate your feedback on that.
from setup-jfrog-cli.
Related Issues (20)
- jf rt u source to destination says success but doesn't upload the artifact to the repository HOT 3
- Upgrade JFrog CLI version to address Maven 3.9.x incompatibility
- version change in action.yaml to 2.50 cli version breaking the existing git workflows. commit https://github.com/jfrog/setup-jfrog-cli/commit/60f0b2eae7e0f3bc79c092fa43587f5592b07339 HOT 1
- Windows runner pwsh not exiting on invalid jf rt upload command
- jfrog commad stuck at configuration and failing HOT 3
- JFrog CLI not reading environment variables correctly HOT 12
- Exchanging JSON web token with an access token failed: Input required and not supplied: oidc-provider-name HOT 9
- Provide the token as output of OIDC authentication HOT 7
- Upgrade to Node.js 20 LTS HOT 3
- (short feature description) HOT 1
- Certificate is Expired HOT 9
- using this action with OIDC auth mechanism produces refreshable token HOT 3
- Paralell jfrog-setup-cli mess up the jfrog-cli.conf.v6 format HOT 1
- Patch request
- Multiple GitHub Runners on self-hosted runner cause permission issue HOT 2
- OIDC integration does not work with Docker when the Identity Mapping is set to Group as the Token Scope on Artifactory's side HOT 2
- Authentication fails with version 4.0.2 HOT 6
- Artifactory returns 404 for private GitHub Docker Repository
- action not using no_proxy (on windows)
- trying to connect lib- dll files from j frog artifactory
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from setup-jfrog-cli.