Giter VIP home page Giter VIP logo

Comments (10)

tbee avatar tbee commented on September 25, 2024

I'm not sure where this code is (man you're doing a lot :-) ), but if it were to be set in the constructor as the default text, then it can be overridden as needed.

from jfxtras.

Maxoudela avatar Maxoudela commented on September 25, 2024

It's situated in the createNodes method of the CalendarTextFieldSkin.

It's in the constructor of the CalendarTextFieldSKin so I don't see how I could override that..?

I'm going through an intense session of Calendar tweak, thus all the enhancements^^

from jfxtras.

tbee avatar tbee commented on September 25, 2024

So if it is in the createNodes, then it will only be executed upon construction and you should be able to overwrite once the control is created?

from jfxtras.

Maxoudela avatar Maxoudela commented on September 25, 2024

Yes indeed you're right! I don't know why I haven't seen that solution before..
Thanks, we can close ;)

from jfxtras.

Maxoudela avatar Maxoudela commented on September 25, 2024

Also on a side note, we have a ColumnConstraints in CalendarTextFieldSKin defined that way :
ColumnConstraints column0 = new ColumnConstraints(100, 10, Double.MAX_VALUE);

Which means we want a minimum width of 100 and a prefWidth of 10... Shouldn't the two values be reversed?

from jfxtras.

tbee avatar tbee commented on September 25, 2024

minimum width of 10 is also weird, so 100,100,max seems more logical?

from jfxtras.

Maxoudela avatar Maxoudela commented on September 25, 2024

Well I have the case where I do put the CalendarTextField in very tiny space. 10 is a bit extreme but 100 minimum is too much IMHO.
I know that it's weird not to display all the date in the TextField, but it's much more weird when the CalendarTextField is going of bounds because the space you want it to be is to tight. In that situation, we can't even see what we're typing..

from jfxtras.

tbee avatar tbee commented on September 25, 2024

Then I'll say: make it so :-)

from jfxtras.

Maxoudela avatar Maxoudela commented on September 25, 2024

Allright it's included in the Pull request :)

from jfxtras.

tbee avatar tbee commented on September 25, 2024

I've added some additional checking on if parse errors are thrown correctly. I hated the stack traces in the console.

from jfxtras.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.