Giter VIP home page Giter VIP logo

Comments (3)

jgazeau avatar jgazeau commented on September 16, 2024 1

Hi @Anaminus ,
Indeed I've checked and actually it would make more sense to follow the bulma size breakpoints, and also it look more smooth at that size. Also as you pointed, no need to hide the toc as it is now collapsed by default on small screen.
I've implemented the changes and it'll soon be available in the master.

from shadocs.

jgazeau avatar jgazeau commented on September 16, 2024

Hi @Anaminus ,
Sorry for the delay.
Indeed, I agree that the difference between just below desktop, and just above desktop is too heavy and should be more smooth.
So based on you're suggestion here are the keypoints:

  • sidebar collapse threshold = 1024px (under which the navbar is collapsed)
  • toc collapse threshold = 1280px (under which the toc is collapsed and also overlapse the main content)
  • toc not visible = 1024px (under which the toc is not visible)

I would put 1280px for the threshold of the toc to match the most common screen width.
Let me know if you agree on that, I'll do it ASAIC.

Regards,

from shadocs.

Anaminus avatar Anaminus commented on September 16, 2024

1280px seems fine, but note that Bulma has a breakpoint at 1216px ("widescreen") which might be easier to use, and more consistent with the rest of the theme.

I think that having the overlapping behavior for the toc would be enough to allow it to be visible at all times. That is, it doesn't need to be hidden below 1024px. This would make navigating pages on mobile a lot easier, and would allow a page's taxonomies to remain available.

from shadocs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.