Log folder not auto created about hector HOT 8 CLOSED

Hmm. This is an easy fix in unix (including Mac OS X), but it turns out to be a real pain to come up with a solution that works on Windows also. I can implement a partial solution that:

• On unix: checks whether or not the log directory exists, if not attempts to create it, and throws an exception on error (including failing to create the file in a directory that exists)
• On windows: throws an error if it fails to create the file (but makes not attempt to fix obvious problems and offers no diagnosis).

Will that suit?

from hector.

I have no problem with Windows being a second-class citizen. Yes, on *nix machines, we auto-create if possible; on Windows, just error out. Sounds good.

from hector.

Pull request incoming. I'll leave the PR open for a day or so in case someone wants to test the windows behavior; otherwise, if nobody objects, I'll accept it myself, since it's a small change.

from hector.

Thanks!

from hector.

Windows VS doesn't recognize this:
#include <unistd.h>
Error: can not include unistd.h no such file or directory

is there something else I need to do?

from hector.

Hmm. Windows isn't supposed to process that line. Evidently it's not defining the _WIN32 macro. Let me figure out what it does define to indicate that the build is happening under windows.

from hector.

for now I just have it commented out.

from hector.

Try the winfix branch. I've tested it on linux, but we will need to test it on OS X as well as windows before we merge it (since this deals specifically with cross-platform issues, it really does need to be tested on each platform individually).

from hector.