Hector version and build numbers should appear in all logs and outputs about hector HOT 11 CLOSED

Good suggestion from @rplzzz : let's include a harcoded version for now, that appears at head of all logs and outputs, pulling from a version.hpp. Later, we'll make this more dynamic, and include Git build hash too.

from hector.

With regards including the version in the output: what do we want that to look like? Do we want to assume some format for a header line? Do we want to include it in every row of output?

from hector.

I am leaning towards a header row with that information.

from hector.

I agree–a single header line in the log (and every visitor output, ideally). E.g.:

Thu Feb  5 12:21:03 2015:DEBUG: Hector version 1.0
Thu Feb  5 12:21:03 2015:DEBUG:init: hello bc
Thu Feb  5 12:24:15 2015:DEBUG:setData: Setting BC_emissions[1765]=0

from hector.

Ok so should I add a header line to the csv output with

# Output from MODEL_NAME version MODEL_VERSION

However is this going to break any R scripts? Doing a quick look it doesn't look like it is expecting any comment.char

from hector.

Yes, it's definitely going to break scripts. But we can fix this, and I think it's worth it to have a header line.

Let's say the logs will look like my previous post above; and the CSV outputs will begin with a line like

# Output from Hector version 1.0

since we're already using # as our comment char in the inputs?

from hector.

Sounds good. I updated op_parser.R as well to set the comment.char="#"

from hector.

Thanks, Pralit.

from hector.

Whoops, I just realized the INI comment character is ; while now in outputs it's #. We should standardize? Any preference @cahartin @rplzzz @pralitp ?

from hector.

I think # is more common and it is already used in the comparison data so I am leaning towards that.

from hector.

Yes, agreed, plus it's used in the R scripts as well. I'll commit the change if no objections.

from hector.