Giter VIP home page Giter VIP logo

Comments (5)

3rd-Eden avatar 3rd-Eden commented on July 28, 2024

Got a bunch of fixes for this said bug in my fork/branch (https://github.com/jgranstrom/sass-extract/compare/master...3rd-Eden:regexp?expand=1) will create a PR for this after I fixed the last set of bugs that I'm running in to.

from sass-extract.

jgranstrom avatar jgranstrom commented on July 28, 2024

Thank you for your efforts in investigating these issues!

I am in addition looking into a more robust parsing method that won't require regexp for reasons like this one. Patches are very welcome for the bugs you come across.

from sass-extract.

3rd-Eden avatar 3rd-Eden commented on July 28, 2024

@jgranstrom Yeah, my branch has a couple of bug fixes already. As for alternate ways to parse there's https://github.com/postcss/postcss-scss which uses a tokenizer but that would require a lot refactoring and I don't know if that is worth the effort as the current regexp's work fine after making them less greedy.

from sass-extract.

jgranstrom avatar jgranstrom commented on July 28, 2024

Great stuff @3rd-Eden. I am looking into using scss-parser for parsing declarations from the AST of each file, which will be helpful in preparations for supporting local variables declared in specific scopes in addition to the global ones currently supported.

from sass-extract.

jrencz avatar jrencz commented on July 28, 2024

@3rd-Eden check out #8 It should fix your issue. It also prevents freezing in my case

from sass-extract.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.