If you have an edge, and add a label to it (either at the end or below, see the image)

Odd behavior of label position on edge about mxgraph HOT 1 CLOSED

nbelyh commented on June 30, 2024

Odd behavior of label position on edge

from mxgraph.

Comments (1)

nbelyh commented on June 30, 2024 1

I think I found the reason, but not sure and therefore would like a developer's feedback. Here it iterates over segments. The thing is , p0 is set too late (and the first point goes wrong)

mxgraph/javascript/src/js/view/mxGraphView.js

Lines 2111 to 2126 in 2ddf544

 for (var i = 2; i < pointCount; i++) 

 { 

 tmp += segments[i - 2]; 

 pe = edgeState.absolutePoints[i]; 

 var dist = mxUtils.ptSegDistSq(p0.x, p0.y, pe.x, pe.y, x, y); 

 if (dist <= minDist) 

 { 

 minDist = dist; 

 index = i - 1; 

 length = tmp; 

 } 

 p0 = pe; 

 }

Shouldn't it be:

			for (var i = 2; i < pointCount; i++)
			{
				tmp += segments[i - 2];
				p0 = pe; // <<<<<<<<<<<<<<<<<<<<<<<<<<<<< here ?
				pe = edgeState.absolutePoints[i];
				var dist = mxUtils.ptSegDistSq(p0.x, p0.y, pe.x, pe.y, x, y);


				if (dist <= minDist)
				{
					minDist = dist;
					index = i - 1;
					length = tmp;
				}
			
			}

If I change it like this, the issue seems to be gone 😄

Please note that this applies (is reproducible) with https://app.diagrams.net/
Example:
https://app.diagrams.net/?title=Untitled%20Diagram.drawio#Uhttps%3A%2F%2Fdrive.google.com%2Fuc%3Fid%3D15aWkaTGpIoZNVGC-XVqIdbghfQh1hRvZ%26export%3Ddownload

from mxgraph.

Odd behavior of label position on edge about mxgraph HOT 1 CLOSED

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	for (var i = 2; i < pointCount; i++)
	{
	tmp += segments[i - 2];
	pe = edgeState.absolutePoints[i];
	var dist = mxUtils.ptSegDistSq(p0.x, p0.y, pe.x, pe.y, x, y);

	if (dist <= minDist)
	{
	minDist = dist;
	index = i - 1;
	length = tmp;
	}

	p0 = pe;
	}