Giter VIP home page Giter VIP logo

Comments (39)

seangates avatar seangates commented on August 15, 2024 14

Um ... an accessible website is the law in most countries and jurisdictions.

If you're considering using Bulma, please know that you could still be held liable.

Therefore, I think labeling it a "feature" is just plain wrong. It should be foundational to the project. Huge miss. I won't be using this framework anytime soon.

from bulma.

xnt avatar xnt commented on August 15, 2024 9

https://en.wikipedia.org/wiki/Web_accessibility#Web_accessibility_legislation

In 2000, an Australian blind man won a $20,000 court case [...] because SOCOG had failed to make their official website, Sydney Olympic Games, adequately accessible to blind users.

In February 2014 a draft law was endorsed by the European Parliament stating that all websites managed by public sector bodies have to be made accessible to everyone.

The Israeli Ministry of Justice recently published regulations requiring Internet websites to comply with Israeli standard 5568, which is based on the W3C Web Content Accessibility Guidelines 2.0.

In Norway, web accessibility is a legal obligation under the Act June 20, 2008 No 42

Among many others. Personally, I worked at an alexa top-50 website not so long ago. ~50% of our team got pulled to a11y for several months due to the very serious threat of legal action from an accessibility lobbying group.

from bulma.

zoe-edwards avatar zoe-edwards commented on August 15, 2024 6

For colour accessibility, if you avoid the buttons and don’t use the greys, actually most things are accesible. At the moment only one of the coloured buttons is somewhat accessible. Just a quick test I did:

Screenshot of buttons from Bulma

Button AA AAA
primary Fail Fail
link Pass Fail
info Fail Fail
success Fail Fail
warning Fail Fail
danger Fail Fail
  • danger does work using large bold text

A lot of people might like the bright colours, but it would be super to provide accesible versions. Not sure if it’s best to make another set or not. At the moment I’m just using the link or the black version.

Also the outlined and inverted ones are the same. You could as one option have black text and a coloured border?

Accessible version of a button

Tested using Colour Contrast Analyser. An online version is also avalible at WebAIM.

from bulma.

jwdallas avatar jwdallas commented on August 15, 2024 5

Hey, a number of these controls do not have focus styles. You seem to have disabled the default focus styles and forgot to add back in your own. This is definitely an accessibility issue within the scope of a CSS framework.

Also super easy to fix. :)

from bulma.

joeldbirch avatar joeldbirch commented on August 15, 2024 5

I also disagree strongly. The web is all about accessibility and it's not hard to avoid breaking that. I don't see a need to give up so easily when the fixes are straight forward. Please see my example above that adds options to improve focus styles.

from bulma.

joshmanders avatar joshmanders commented on August 15, 2024 4

I'd also like to see accessibility cared about in this framework.

from bulma.

jessaleks avatar jessaleks commented on August 15, 2024 4

@VizuaaLOG how is making Bulma accessible to everyone not a priority?

Informing people is why the internet was created in the first place. How can the internet serve it's purpose if people can barely read things?

It's not just the buttons. Take a look:
image

That simply can't be.

from bulma.

johncaseysmith avatar johncaseysmith commented on August 15, 2024 3

I would argue against a tag specifically for high contrast, since the actual problem is that the colors don't even meet the minimum requirements for contrast as they are. So really, the "high contrast" should be the standard. Regular text must have a contrast ratio of 4.5:1 to comply with the WCAG 2.0 standards.

And I second the focus styles being important and easy. Take care with outlines and take care with that tab panel. You have a huge opportunity here to improve the accessibility of every website using this framework, I hope it isn't squandered! A great feature would be CSS markup based on role attributes.

from bulma.

jgthms avatar jgthms commented on August 15, 2024 3

@Muhnad has already made a few PRs to improve the doc code snippets.

I agree that more work needs to be done. I'm not an expert in accessibility, so any help would be appreciated!

from bulma.

chrisdemars avatar chrisdemars commented on August 15, 2024 3

@viion You now have people who want to fix whateve a11y issues there are. I didn't know about any issues until a friend directed me here because of my accessibility advocacy. Getting to AAA WILL never happen so that can be buried, BUT it should still meet AA WCAG guidelines.

from bulma.

mikestreety avatar mikestreety commented on August 15, 2024 3

Adding a note to this as I have just started using Bulma and noticed the examples for the forms are missing for="" attributes on labels and id="" attributes on inputs.

E.g.

<div class="field">
  <label class="label">Name</label>
  <div class="control">
    <input class="input" type="text" placeholder="Text input">
  </div>
</div>

Becomes

<div class="field">
  <label class="label" for="name">Name</label>
  <div class="control">
    <input class="input" type="text" placeholder="Text input" id="name">
  </div>
</div>

from bulma.

chmanie avatar chmanie commented on August 15, 2024 2

Most accessibility features are tied to the HTML markup, not the CSS. So it goes beyond the scope of Bulma, which is a CSS framework after all.

That's true, but a CSS framework could do the job of making accessibility more accessible :)

For example also supporting aria states for CSS styling.

from bulma.

septatrix avatar septatrix commented on August 15, 2024 2

Today I also noticed that the contrast on message boxes is too low. It would be nice if the SCSS functions generating the relevant colors (dark and light) would yield a high enough contrast.

Currently this is sadly stopping us from adopting Bulma besides some personal projects of mine in which I have liked the experience so far.

from bulma.

joeldbirch avatar joeldbirch commented on August 15, 2024 1

I'd like to see the focus styles improved as they are barely noticeable, but I'd settle for variables that allow me to override the box-shadow spread, blur and opacity. For example, in the current button.sass file:

&:focus,
  &.is-focused
    border-color: $button-focus-border
    box-shadow: 0 0 0.5em rgba($button-focus-border, 0.25)

This could be changed to something like:

&:focus,
  &.is-focused
    border-color: $button-focus-border
    box-shadow: 0 0 $button-focus-blur $button-focus-spread rgba($button-focus-border, $button-focus-opacity)

That would help greatly. I'll try to make a pull request once the heat is off for current project, but hopefully someone will beat me to it.

from bulma.

vekien avatar vekien commented on August 15, 2024 1

To note: this was posted over a year ago, it's old. Much of my OP has either been solved or wouldn't be appropriate for the "feel" of bulma.

There is much more than just focus styles @joeldbirch .... The current colours if used as text. You could tweak these but it would ruin the look of Bulma. Aria roles have been implemented which is a good sign, but missing in crucial areas (eg forms). HTML examples all looks better, I'm not a frontend dev but the obvious ones I posted in my OP I don't see anymore.

The reason I originally said close is this issue has been sat here for 18 months with no sign of work, not even a simple PR/Commit reference. Also due to most of the issues either being complete or nearish, smaller topics may be more suitable to tracking what is left to do. As for why I think not all frameworks need to be accessible, if you truely want Bulma to be AAA Pass 100% accessible you're going to have to adjust it colours a lot and in my opinion this would ruin it's look and feel. Not even BS passes accessibility contrast for coloured text.

However this is up to the creator and the support from posts, at least my post got people talking again on this topic which I do believe is important. I'll take that heat for my previous comment as it has brought out a few people who want to show their strong support, that is a win in my eyes.

From a profession point of view I would always need to pick the framework which is supporting the most right now.

from bulma.

zoe-edwards avatar zoe-edwards commented on August 15, 2024 1

Having played around a little, this works to make an outlined button with accessible text:

<button class="button is-primary is-outlined has-text-dark">Button</button>

However, when you hover over it it then becomes inaccessible.

Would a PR be supported for something like this?

<button class="button is-primary is-bordered">Button</button>

My proposal is that it would keep the has-text-dark colour throughout, and that either have no hover state (as that’s perfectly accessible), or something else.

from bulma.

jessaleks avatar jessaleks commented on August 15, 2024 1

Ok folks, it's June 2019, and it still is nowhere near being fixed. It's 3 years now.

I really like the teal-ish primary color. What I don't like, however, is having the contrast ratio of JUST 1.95 between primary button's text and background.

Most folks might customize the color theme right away, and they probably will continue to do so, however some don't and won't.

from bulma.

alejandroiglesias avatar alejandroiglesias commented on August 15, 2024 1

@VizuaaLOG I'm wondering if core developers share your opinion in that it shouldn't be used in production. That would worry me since we're already using it in production.

Screen Shot 2019-07-26 at 13 56 52

from bulma.

jgthms avatar jgthms commented on August 15, 2024

Yes, accessibility has not been tackled at all for now.

Most accessibility features are tied to the HTML markup, not the CSS. So it goes beyond the scope of Bulma, which is a CSS framework after all.

I like the idea of the high contrast flag that could be added in the variables. We could have functions to calculate those colors (like the findColorInvert function that's already being used).

If you want to update the HTML markup of the docs, feel free to submit a PR on the relevant repo: https://github.com/jgthms/bulma-website

I'll leave this issue open for discussion.

from bulma.

xnt avatar xnt commented on August 15, 2024

@viion - Since you seem to have identified a few different problems, it'd be awesome if you could break down this issue into smaller chunks. I'd be more than happy to address at least some of them, but the scope of this particular ticket seems to big and even risky for a single PR...

from bulma.

chrisdemars avatar chrisdemars commented on August 15, 2024

I disagree with that statement @viion. This framework should definitely be accessible to all users. It should stay open so someone can work on it. I can take a crack at it.

from bulma.

chrisdemars avatar chrisdemars commented on August 15, 2024

To @joeldbirch's point. I give a talk at conferences all about CSS and focus styles. This really is not a huge task.

from bulma.

Muhnad avatar Muhnad commented on August 15, 2024

Hi all,

of course, the framework needs more enhancements about accessibility but everybody blames the framework owner about this issue and I see you should blame yourself first because you know this framework is not accessible and you don't try to help and fix this issue.

no one knows everything if you know something you should help other, so we should all help the framework and make it accessible for everyone to make the framework great again 😄

so thanks @viion for reporting this issue and we hope to open more specific issues about accessibility issues and if you can help to enhance the code that will be better.

everybody cares about users & web and can help us to enhance the framework would be appreciated 😄

from bulma.

xnt avatar xnt commented on August 15, 2024

@viion regarding colour contrast, although not an ideal fix, I have successfully used the -ms-high-contrast media query for targeting IE users with high contrast mode turned on. Windows-only, IE/Edge-only, but I guess it's better than nothing. Admittedly, for these users, Bulma would look a bit ugly. But well, at least they would be able to see it :) .

I think it'd be fantastic if we can address this. By "huge" I meant that the acceptance criteria for closing this particular ticket was a bit too wide, and maybe instead we'd like to chop it down into tiny little chunks that could be addressed on a more atomic manner, whilst minimizing the PR conflicts.

from bulma.

peterblazejewicz avatar peterblazejewicz commented on August 15, 2024

HTML syntax is invalid, eg: Button - Links are not buttons

BTW, this syntax is OK, the a tag can work as placholder under HTML5 (a:not(:link), a:not([href]) ):
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#Attributes
That's up to library what to do with placeholder links.

from bulma.

chrisdemars avatar chrisdemars commented on August 15, 2024

from bulma.

seangates avatar seangates commented on August 15, 2024

Of course you won't go to jail. I never said anything about jail or even a fine by the government.

But you can certainly be sued. Again, it depends where you live: https://www.employerlawreport.com/2015/12/articles/eeo/website-accessibility-regulations-delayed-until-2018-but-businesses-should-not-table-the-issue-until-then/

Beginning in 2006, private litigants and the DOJ began filing or threatening to file legal action based on allegedly inaccessible websites (and eventually also including mobile applications). The law is unsettled on whether websites and mobile applications are places of public accommodation under the ADA. Some courts have held that they are, and others have ruled otherwise. The Third, Ninth, and Eleventh Circuit courts apply the ADA only to websites that have a connection to goods and services available at a physical location, like a retail store. The theory in those cases is that the store is a place of public accommodation, and “shopping there” online requires accessibility of the website. The First, Second, and Seventh Circuit courts apply the ADA more broadly to include all websites that offer direct sale of goods or services, even those that lack “some connection to physical space.” Since web-based businesses can be sued anywhere they are regularly transacting business, litigants can select their forum based on which has the most favorable law. With e-commerce, that likely subjects many businesses to suit in all 50 states.

Basically, you can be sued using the ADA, if you don't comply with the accessibility standards set forth in the WCAG guidelines.

Further: https://www.w3.org/WAI/policies/

from bulma.

seangates avatar seangates commented on August 15, 2024

Also, it's just the right thing to do for many, many people.

from bulma.

seangates avatar seangates commented on August 15, 2024

☝️

from bulma.

vekien avatar vekien commented on August 15, 2024

It’s very important to differentiate the difference between the claims and law vs what is required, you are not going to get sued because your submit button didn’t have the right contrast.

There is also an expectation of example from sites like the Olympics, eg was the site just a big video overlay?

Demanding action because of laws don’t make accessibility integration black and white, look at GDPR as an example of law vs outcome.

Also happy 2+ years 🎉 when I brought these issues up, anyone up for documenting what is left to do?

from bulma.

miklb avatar miklb commented on August 15, 2024

I believe the default colors are still not WCAG AA compliant. That's what got me here via a search anyway.

from bulma.

jaimeiniesta avatar jaimeiniesta commented on August 15, 2024

Hey there, in case it helps detecting accessibility issues here, I've run a report on the main site (which I suppose uses the Bulma framework) and here are the HTML and A11Y issues found:

https://rocketvalidator.com/s/a7949c11-7654-4544-afc8-b3f938f37bb5/p

I'll be happy to provide a larger report, or to set up a schedule on this site to have it monitored if you wish.

from bulma.

kiwanska avatar kiwanska commented on August 15, 2024

I'm happy to help with fixing all the accessibility issues if we have a good website for testing – anybody able to share a website that uses Bulma heavily so I can run accessibility test on it and fix one by one?

from bulma.

chrisdemars avatar chrisdemars commented on August 15, 2024

from bulma.

jaimeiniesta avatar jaimeiniesta commented on August 15, 2024

@kiwanska @chrisdemars I can give you free Pro accounts on Rocket Validator to crawl your test sites and run axe-core A11Y checks automatically, I'll ping you by email.

from bulma.

VizuaaLOG avatar VizuaaLOG commented on August 15, 2024

@TheNathurat this is an open source project. You're welcome to create a PR. Bulma is still in the beta phase so is probably not a priority at the moment.

from bulma.

VizuaaLOG avatar VizuaaLOG commented on August 15, 2024

I didn't say it's not a priority ever. I said it is probably not an priority at the moment.

Once it is released fully released then I'm sure it would be a priority. It's in a beta phase and so shouldn't really be used in any production project, even though it is fairly stable.

from bulma.

aviv-or avatar aviv-or commented on August 15, 2024

@VizuaaLOG I'm wondering if core developers share your opinion in that it shouldn't be used in production. That would worry me since we're already using it in production.

Screen Shot 2019-07-26 at 13 56 52

I completely agree, this framework looks nice visually but as soon as i looked whats under the hood, its really lacking. It's not production ready at all. The way i see it, the creators of design systems / CSS frameworks need to take a responsibility for the majority of developers who basically know nothing about accessibility. At the very least, the use of proper colors and the right contrast should be mandatory.

from bulma.

seangates avatar seangates commented on August 15, 2024

Yup. That's why we at eBay have a CSS framework which enforces accessible practices called Skin, as well as a front-end framework called eBayUI Core which has accessibility baked in for developers to focus on solving business problems.

We welcome any feedback!

from bulma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.