Nested Tabs - almost works about docsify-tabs HOT 7 CLOSED

Hi @gotjoshua.

Per the Features/Limitations section of the docs:

Limitations

• Nested tabsets (i.e. tabs within tabs) are not supported.

Nested tabsets are challenging as a result of how markdown needs to be parsed and HTML needs to be generated/inserted within the docsify plugin system. I'm sure it can be done, but after a few failed attempts I decided to move on assuming it wasn't a common use case. If there is a strong need for nested tabsets, let me know and we can discuss further.

I do really like your idea of providing tabs for markdown output and code on the Markdown page! I may explore this a bit and update the docsify-themeable accordingly. 😄

from docsify-tabs.

from docsify-tabs.

I appreciate you taking the time to file the issue. 😄

I have updated the Markdown section on the docsify-themeable website with the tabs per your suggestion. Great idea.

Thanks again, @gotjoshua.

from docsify-tabs.

Great that you like the tabbed markdown cheatsheet!

A last thought about nested:

Could it work to add an identifier to the comment blocks for start and end?
Not required, but always checked for in case nested tabs are wished.
eg:

<!-- tabs:start<<<OUTER -->
#### **outer tab containing nested tabs**
content above tabs
<!-- tabs:start<<<INNER -->
#### **inner tab contents**
<!-- tabs:end:INNER-->
#### **2nd outer tab without nested tabs**
content
<!-- tabs:end:OUTER -->

The idea is inspired by "Heredoc" multiline string syntax

Could this strategy make parsing more possible?

(I looked at the index.js code, but I don't have time to offer a PR, sorry)

from docsify-tabs.

Possibly, but that would add complexity for the end user which I would like to avoid if possible.

If nested tabs becomes an issue that needs to be solved, then I would most likely start with a library like balanced-match to (hopefully) make parsing tabsets easier. I didn't do this initially because parsing is pretty easy when you aren't worried about nested tabs and I didn't want to add a dependency unnecessarily.

For now, I'll chalk this up as a +1 for nested tabs. The other issue that needs to be resolved is tab wrapping on small screens. I'd like to address both of these issues at some point in the future, but for now I'm focused on other projects. If/when nested tabsets becomes an issue for you, give me a shout and I'll see if I have the bandwidth to make the necessary updates.

from docsify-tabs.

FYI, nested tabs are now supported as of v1.6.0.

from docsify-tabs.

nested tabs are now supported

👌👍🤩🙏

from docsify-tabs.