MAX() function always returns 0 about fselect HOT 4 CLOSED

Well, i found the issues.

The MAX function only works if it can cast the value to usize, otherwise it ignores the value, so that explains why fselect "MAX(modified) from /tmp/test" didn't work. I assume that's intended behavior.

The issue with fselect "MAX(YEAR(modified)) from /tmp/test" (as well as fselect "MIN(YEAR(modified)) from /home/user", which is an example from the docs) is that it will look for Year(Modified) in the hasmap from the raw_output_buffer, but that hasmap only contains the raw Modified and an empty Min(Year(Modified)).
That means a really simple workaround is to use this query: MIN(YEAR(modified)), YEAR(modified) from /tmp/test., which will make fselect compute the needed Year(Modified).

I tried fixing it myself, but i can't really understand the structure of the code, especially since it doesn't have many comments.

from fselect.

from fselect.

Thank you very much for this issue!

Indeed, the code is an undocumented mess... It appears, a deliberate "shortcut" has been made at some point, so the aggregates didn't work with the enclosed functions.

I added a small fix to the master branch. It would be great to check if it works for you now.

MIN and MAX for datetime fields is actually an another problem. Will add it soon, I guess :)

from fselect.

Works fine now!
About the lack of code comments, would you accept a PR that reformats / documents some of the code?

from fselect.