Giter VIP home page Giter VIP logo

Comments (12)

jimschubert avatar jimschubert commented on August 22, 2024

I have never had this issue and I've not had anyone bring it up in nearly 3 years of the extension being live in the Chrome store. Are you sure it isn't another extension reloading the page? New Tab Redirect doesn't contain any content scripts which would cause your homepage to re-render or redirect.

When Chrome crashes, it should open to your home page (which is different from chrome://newtab). I use the stable, dev, and canary branches of Chrome and have crashes pretty frequently, but I've never had the "Restore Tabs" message disappear.

You can add a bookmark and point it to chrome-internal://newtab. The original new tab page includes a "Recently Closed" dropdown in the bottom-right corner which should allow you to open your lost tabs after a crash.

Also, note in the readme that it says:

This is not meant to replace your homepage, only new tabs. If your browser is set to load the New Tab page as your homepage, there may be odd consequences.

If you have set your homepage to the new tab page, this is an odd consequence.

from newtab-redirect.

rshaw22 avatar rshaw22 commented on August 22, 2024

Jim,

I'm sure the redirecting is via NT-Redirect. I have only a few extensions and no others have to do with redirecting. The behavior matches what NT-Redirect normally does (e.g. resulting page has one entry under it in the visiting-page list, which is labeled "Redirecting..." and Back button does redirect as usual back to NTR target.

I have NT-Redirect configured with a target of a file on my C: drive and using 'Hide "Redirecting..." hint' option. Chrome is configured with the same file under 'Show Home button' (not 'Use the New Tab page' option) and "On startup" is 'Continue where I left off'. I'm using chrome 20.0.1132.34 beta-m which I believe is current Dev thread version. OS is more or less up to date Windows Vista.

I just tested if I could repeat it, and did. After externally stopping the chrome processes, starting chrome again momentarily showed the "crashed, would you like to restore pages" dialog line which was then replaced with the NTR target page, again with "Redirecting..." shown in the back-stack.
One possible difference this time is that when I invoked my chrome-internal://newtab bookmark, the 'recently closed' list did in have the various "7 tabs" etc. entries for the windows at the time of the crash, whereas the painful first experience did not show them if I recall correctly (although maybe they had been pushed off the bottom of the list by my activity, but I don't think so as I think I tried that pretty early on).

from newtab-redirect.

jimschubert avatar jimschubert commented on August 22, 2024

Thanks for providing a thorough description of your experience.

I am able to reproduce this when force-closing the chrome.exe process in Windows. My Chrome version is 21.0.1180.0 (Official Build 142910) dev-m. Randomly, the browser will show the Restore button and not redirect via New Tab Redirect while other times it acts as you've described.

As I mentioned before, I've had Chrome crash naturally and not had the same experience but this may have been in the stable branch. I'm not sure why the beta/dev branches open the New Tab page instead of the home page because it usually displays iGoogle after a natural crash. This could also be a difference between Chrome on Ubuntu (which I usually use) and Chrome on Windows.

As I have time, I will test this in each branch. Because the original New Tab page provides the recently-closed tabs option, and because I'm not sure Chrome offers a way to check if the extension has started after a crash, I'm don't know if it's even possible to modify this behavior at the extension level.

from newtab-redirect.

bbodenmiller avatar bbodenmiller commented on August 22, 2024

I too am having this problem and have had it for some time. If my browser crashes and I reopen it I must click the Restore button immediately or I am quickly directed to the redirect I have setup via this extension. Additionally if I try right-clicking the top bar and selecting Reopen closed tab after this has occurred that option is grayed out. Running Version 28.0.1500.20 dev-m but like I said it has been going on for awhile. Additionally I have On startup set to Continue where I left off.

from newtab-redirect.

markeganfuller avatar markeganfuller commented on August 22, 2024

I just hit this too, very annoying and I can't find any other way to restore tabs beyond that button.

Version 27.0.1453.93

from newtab-redirect.

bbodenmiller avatar bbodenmiller commented on August 22, 2024

Any updates on getting this fixed? Sadly without a fix for this I may have to uninstall this extension.

from newtab-redirect.

jimschubert avatar jimschubert commented on August 22, 2024

Are you guys familiar with the CTRL+SHIFT+T or COMMAND+SHIFT+T shortcut to open previous tabs? This should open all previous tabs.

Also, across crashes, if you got to the original chrome new tab page (chrome://apps), there is a "Recently Closed" option in the bottom right of the page. You'll see previous full sessions display as a tab count (e.g. "27 tabs").

I've been busy preparing for my baby, he is due on Nov. 5. I will look into a possible fix soon. I apologize for the late responses, GitHub has apparently stopped notifying me by email of new issues and I was unaware this had changed.

from newtab-redirect.

bbodenmiller avatar bbodenmiller commented on August 22, 2024

I'm assuming CTRL+SHIFT+T is the same as right clicking and selecting open closed tabs which previously has been grayed out after being redirected after a crash.

from newtab-redirect.

struffus avatar struffus commented on August 22, 2024

I'm also having this issue in Chrome for Mac version 31.0.1650.57 on Mac OSX 10.8.5.

from newtab-redirect.

jimschubert avatar jimschubert commented on August 22, 2024

Do you have crash reporting enabled? go to chrome://crashes and see what caused the crash.

Unfortunately, there is no way for an extension to detect that the browser has crashed, and it is the browser causing this weird behavior as a side effect of NTR (not really NTR) causing it. Again, CMD+SHIFT+T will open all previous tabs across crashes or browser shutdowns of any sort.

I'm closing this issue because there's no feasible way for me to handle the issue (considering the browser doesn't provide a way to detect crashes).

from newtab-redirect.

bbodenmiller avatar bbodenmiller commented on August 22, 2024

I respectfully disagree that this extension is not causing a conflict with tab restore. I still am able to restore tabs without this extension but not with it. I'll get back to you when I can provide reproduce steps to force it.

from newtab-redirect.

jimschubert avatar jimschubert commented on August 22, 2024

I don't disagree that with the extension installed, Chrome eats up the 'Restore' option. Unless Chrome provides me with an API to detect crashes, there's literally nothing I can do. Even if the browser provided an option to detect crashes, I'd have to rewrite New Tab Redirect to be a tab management extension, which is not something I'm willing to do. Considering Chrome provides a way to open all previous tabs easily (via hotkey and via the original new tab page), my continued investigation into a missing feature of Chrome is a waste of time.

My suggestion would be to fix whatever is causing the crash. Go to chrome://crashes and take a look around. If you don't have crash reporting enabled, enable it (sends anonymous data to Google, though). I've gone over two years without the browser crashing and to test this, I have to literally kill the process. Even then, on Ubuntu 13.10 both Chrome and Chromium reopen all tabs as they were with and without New Tab Redirect enabled (and with/without it installed). Same on OS X. With New Tab Redirect installed and enabled, I even made sure all tabs within the window were tabs redirected to some site by New Tab Redirect.

Do you guys have the 'Continue where I left off' option enabled in chrome://settings under On Startup? That's the only thing I think could be different between our experiences. Again, Chrome causes this and yet provides simple fixes.

To explain a little more why I'm not willing to make New Tab Redirect a tab management extension:

  • I already get about 5 emails a week from marketers begging me to add their crap to the extension so they can spy on my users... replying that the extension uses an event page and is therefore only in memory for a very small amount of time causes them to back off quickly. I had one guy hassle me for like 10 replies until I blocked his emails.
  • Tab management would require a session, which requires me to 'collect data' about users (even storing a session id will make a lot of the users throw a huge fit). I don't want to deal with that. In fact, I've vowed to never collected data from my users.
  • The whole point of New Tab Redirect's redirect.html page is to be very small and quick. Tab management would have to be moved into a background page (background.js could then not be an event page) that has to be long-running and persistent in memory. Users HATED that before Chrome introduced event pages.

from newtab-redirect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.