Giter VIP home page Giter VIP logo

Comments (3)

jinzhu avatar jinzhu commented on July 17, 2024

I think no one would export all method from package io and copier at the same time with this:

import . "io"
import . "copier"

And even someone are doing like this, he will get compile error!

So of course, no existing code would be break.

from copier.

rce avatar rce commented on July 17, 2024

That's not what I tried to say. I was saying that the destination, source order of parameters would be more idiomatic because of the consistency with io.Copy's parameters.

from copier.

jinzhu avatar jinzhu commented on July 17, 2024

Sorry, I didn't read you comment carefully... ;(

Yes, you are right. it would be a better to change the order.

Just did it hope won't affect any others due to the breaking change ;(

from copier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.