Comments (11)
Hey, sry been quite busy with some other stuff. I hope to give you feedback within this week. However, commit looks good 👍
from ads-client.
Hi Andy!
There seems no reason why not to update it. However, just wondering, shouldn't the "iconv-lite": "^0.5.2"
in package.json mean that it should install the most recent 0.x.x version always? So 0.6.2 would be installed? Or am I understanding something wrong?
Ps. Been wanting to try Electron and this library too, but haven't got time yet. Let me know how it goes.
from ads-client.
Hey, thanks for the quick reply.
That holds true for all Versions greater than 1.0.0. However, npm treats the 0.x.y version as pre-release and does not apply the same logic (as it is expected to have breaking changes between 0.5.y and 0.6.y for example).
from ads-client.
Oh I see. Thanks for the info!
I'll update the package.json in few days.
from ads-client.
Thanks alot!
I also had issues with following statements (ads-client-ads.js)
return ((ret = Object.keys(this).find(key => this[key] == "asd")) != null ? ret : 'UNKNOWN')
due to the fact that ret is not declared as let/const/var. While this works in plain JS, in my environment it did not.
I replaced it with following code to get it running:
return (Object.keys(this).find(key => this[key] == value)) || 'UNKNOWN';
Should I open another issue for this?
Best regards
Andy
from ads-client.
No need to, I'll check them out too! Thanks for reporting, The original code makes no sense :D
from ads-client.
Sorry for delay, been a little busy. I'll do this today or tomorrow!
from ads-client.
No worries, just text when you're done and I'll verify the new version. Thanks for your effort!
from ads-client.
Just released new version, let me know how it goes!
from ads-client.
Hey @enenkel! Any news? :)
from ads-client.
I'm closing this now. If there are problems you can create a new issue.
from ads-client.
Related Issues (20)
- Read symbol value on BC9050 HOT 2
- MBUS card through ADS HOT 1
- BK9050 HOT 11
- idea: ads-client with Blockly, organization: VisualPLC, problem port 301 without address, HOT 11
- CX9020 HOT 1
- Get events/alarms/messages from TcEventLogger HOT 3
- write variable type BOOL HOT 1
- ads-client+vite+vanillajs it's possible? HOT 5
- Subcribe to variable without PLC port 301 HOT 1
- Version 2 - Missing features from v1 HOT 9
- Version 2 - Adding support for SymbolInfo and DataType extended flags
- Version 2 - Making sure 1.4.2 and 1.4.3 updates are merged HOT 2
- Version 2 - Pull requests
- Version 2 - README
- Version 2 - MIGRATION HOT 1
- Version 2 - Documentation
- Version 2 - Finalizing types HOT 1
- Version 2 - Finalizing testing
- Version 2 - Reconnecting and handling subscriptions during reconnection and symbol version change HOT 1
- Time datatype HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ads-client.