Giter VIP home page Giter VIP logo

Comments (10)

bgrozev avatar bgrozev commented on July 21, 2024

Do you see any jvb log messages containing "initialLastN"?

from jitsi-videobridge.

bukharin avatar bukharin commented on July 21, 2024

@bgrozev yes, it has

Setting initialLastN = 1

Also I try to disable sending ReceiverVideoConstraints message in lib-jitsi-meet. In this case I see the same behaivour. It seems that JVB always sends ForwardedSources message with all endpoints.

image

from jitsi-videobridge.

bgrozev avatar bgrozev commented on July 21, 2024

That's strange and I can't reproduce it. Do you use SCTP or WS for the data channel?

from jitsi-videobridge.

bukharin avatar bukharin commented on July 21, 2024

WebSockets, the screenshots above were taken from Chrome DevTools

from jitsi-videobridge.

bgrozev avatar bgrozev commented on July 21, 2024

I think I see how this happens. The WS must have been established before the bridge received the initial-last-n from jicofo. In this case the bridge will send the initial forwarded sources message (with lastN=-1), then send the updated on (with lastN=1) once it receives initial-last-n.

I'm surprised it happens often, because the WS requires at least an extra RTT for the TCP handshake, while the initial-last-n is just a packet sent to jicofo which immediately updates the bridge via an existing connection.

For your use case, would it work if we add a config option to the bridge setting a default initial lastN value?

from jitsi-videobridge.

bukharin avatar bukharin commented on July 21, 2024

@bgrozev yes, you are right. It's a race condition.

In my case I see the problem exist in 9 of 10 attempts. May be initial-last-n should be a parameter when jicofo allocate user session on JVB to prevent this race condition ?

from jitsi-videobridge.

bgrozev avatar bgrozev commented on July 21, 2024

Jicofo doesn't have that information about a participant when it does the allocation. It only has the set of capabilities (i.e. just booleans) and presence. We want to avoid adding it in presence because it's broadcast to everyone.

Longer term using SCTP where the race doesn't exist might be the best option. That's why I'm looking for some easy workaround instead of a proper solution which would require more time that we can't invest. If you control your environment and want initial-last-n=1 for everyone I'm happy to add a configurable default in the bridge.

from jitsi-videobridge.

bukharin avatar bukharin commented on July 21, 2024

@bgrozev I'd love to have initial-last-n as a configurable option of JVB

from jitsi-videobridge.

bgrozev avatar bgrozev commented on July 21, 2024

It's a very simple change, so I'll assume it works. Re-open if necessary.

from jitsi-videobridge.

bukharin avatar bukharin commented on July 21, 2024

@bgrozev yes, it works! Thanks you

PS: I think this condition appears when RTT between end user and bridge less than RTT between user and jicofo

from jitsi-videobridge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.