Possibly separate KeplerGLBase and KeplerGL? about keplergl.jl HOT 8 CLOSED

Thank you, yes, I can take care of the documentation and readme. I've initiated the registration of KeplerGLBase; once it's in the registry I'll check whether the tests in KeplerGL.jl pass.

As for the docs, I'm inclined to keep them in KeplerGL.jl for the time being (perhaps with a link from the KeplerGLBase.jl readme as well), because this is the place where people might look for it (also PlotlyBase is doing something similar it seems).

from keplergl.jl.

Hi @hhaensel ,

Thanks a lot for your message, glad that someone found the package useful.

Yes, absolutely, I'm all in favour of separating the WebIO/Blink parts from the JSON generation. However, (1) I'm an absolute rookie when it comes to anything web/JS/react; I could copy the structure of the PlotlyBase/PlotlyJS separation but wouldn't be sure whether that fits with your use case; (2) the next weeks/months are busy for me so I don't have a sense for when I would be able to get to this.

Bottom line, please feel to go ahead with this. If you want, I can create a KeplerGLBase.jl repo and you can separate out the base parts of KeplerGL.jl and put it in there, and then I'll put the display code in here whenever I get to it.

from keplergl.jl.

Creating KeplerGLBase would be great, I'll provide PRs in both packages then.

from keplergl.jl.

If you do so, best would be to make it a copy of KeplerGL.jl then changes are less.

from keplergl.jl.

Great, see here

from keplergl.jl.

I have created two PRs in KeplerGL and KeplerGLBase.

What I have done:

• moved most of the package KeplerGL to KeplerGLBase
• adapted the tests so that all pass
• kept all WebIO and Blink related functions in KeplerGL
• changed the references to the assets
• reexported KeplerGLBase
• changed the example code in KeplerGL's README.jl
• removed all Manifests.toml files

What I have not done

• moved or touched the docs
• changed the README of KeplerGLBase

I hope this is a good first step.

@jmboehm would you find the time to address the last two points?

from keplergl.jl.

Fixed by #10 and #13, thanks a lot @hhaensel !

from keplergl.jl.

Welcome 😄
Thanks for your strong support

from keplergl.jl.