Comments (5)
Repository was added in 2.1.0. I'll fix the format issue at a later time. The micro optimization was kept out for readability and I don't think it's going to make or break someones time controlled flow, but it's a good call out.
from nest-lab.
Thanks for pointing this out, I'll get it added. Shame it'll have to be added to npm as a patch for no real code change
from nest-lab.
I believe there's a place for a minor refactoring here:
- return throwError(err);
+ return throwError(() => err);
And formatting
- import { catchError, last, mergeMap, takeWhile} from 'rxjs/operators';
+ import { catchError, last, mergeMap, takeWhile } from 'rxjs/operators';
😄
from nest-lab.
Good catch. Also, no clue why I haven't fixed this yet. Whoops
from nest-lab.
another one(?) would be on the following part
nest-lab/packages/or-guard/src/lib/or.guard.ts
Lines 30 to 34 in bc04b4c
as that guard
private field isn't used anywhere but on canActivate
, why not just drop it (micro-optimization here)
canActivate(context: ExecutionContext): Observable<boolean> {
const canActivateReturns: Array<Observable<boolean>> = guards.map(
(guard) => this.deferGuard(this.modRef.get(guard), context)
);
}
from nest-lab.
Related Issues (9)
- Create Node HTTP adapter for NestJS (raw HTTP adapter, no underlying framework) HOT 1
- Create `@nest-lab/deepkit` for `@deepkit/type` integration with the ValidatiojnPipe and CLassSerializationInterceptor
- FastifyError: Content type parser 'multipart' already present.
- Default MulterOptions does not save to storage HOT 4
- Create a @nest-lab/multer where a multer package can be plugged in to work with the used http adapter HOT 1
- Question: Using typeschema with nestjs/config HOT 1
- Issue with AndGuard guards execution order HOT 7
- Add stream support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nest-lab.